Re: [PATCH] ncurses based config V2

Roman Zippel
2008-11-25T02:34:28Z

Hi,

On Mon, 24 Nov 2008, Sam Ravnborg wrote:

> > - colors are too dark.
> Seconded. Please try to find a lighter set of default colors.
> You may be inspired by one of the menuconfig color-sets.
>
> I agree that we could use a lift here - so please do not go for the
> default color set of menuconfig.

Well, the current colors seems to usable on wide variety of terminals, but
I'm not colorblind, so I can't really complain. :)
Before we keep discussing the colors, I'd rather suggest to drop them
completely and maybe use colors for what actually needs attention.

> > - I'm not convinced that the parenthesis around hotkeys make the menu
> > that much readable, especially when there are lots of short words or
> > even acronyms. Eg :
> > [ ] (U)TS namespace
> > [ ] (I)PC namespace
> > [ ] (U)ser namespace (EXPERIMENTAL)
> > [ ] (P)ID Namespaces (EXPERIMENTAL)
>
> This looks like some ancient stuff and it must be a better way to
> show the short-cuts.

The parenthesis make it really annoying to read...

> I would really appreciate if you could look into the above issues.
> If you do a repost with this fixed I will try to do a proper review,
> including code-review next time.

The code is rather large, so it might be better to split the code into two
sources, one for kconfig logic and the other for the interface logic, so
it becomes easier to read and maintain.

bye, Roman