Re: [PATCH] ncurses based config

Randy.Dunlap
2008-09-03T20:02:43Z

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1807 bytes --]

On Wed, 3 Sep 2008, Bartlomiej Zolnierkiewicz wrote:

>
> Hi,
>
> On Wednesday 03 September 2008, Nir Tzachar wrote:
> > This patch was inspired by the kernel projects page, where an ncurses
> > replacement for menuconfig was mentioned (by Sam Ravnborg).
> >
> > Building on menuconfig, this patch implements a more modern look interface using
> > ncurses and ncurses' satellite libraries (menu, panel, form). The implementation
> > does not depend on lxdialog, which is currently distributed with the kernel.
> >
> > The only change outside of nconf.c is due to a name clash: both ncurses and
> > lkc.h define a fucntion named menu_init(). I changed the internal version's
> > name.
> >
> > Please consider the patch for merging. Comments are appreciated.
>
> Could you please tell what kernel version is it against?

It applies cleanly to 2.6.27-rc5-git4 FWIW.

> I'm getting the following error on make nconfig (and also on make menuconfig
> which works fine without this patch) with the current Linus' tree:
>
> HOSTCC scripts/kconfig/conf.o
> HOSTCC scripts/kconfig/kxgettext.o
> HOSTCC scripts/kconfig/nconf.o
> HOSTCC scripts/kconfig/zconf.tab.o
> scripts/kconfig/zconf.tab.c: In function ÿÿconf_parseÿÿ:
> scripts/kconfig/zconf.tab.c:2258: warning: implicit declaration of function ÿÿmenu_initÿÿ
> HOSTLD scripts/kconfig/nconf
> scripts/kconfig/nconf arch/x86/Kconfig
> make[1]: *** [nconfig] Segmentation fault
> make: *** [nconfig] Error 2

Need to change all /menu_init/ in zconf.tab.c* to /_menu_init/.

Need to strip trailing whitespace on new source code lines.

I'm seeing cyan (?) foreground on black background. Is that the colors
that were planned?

Instructions are dark blue on black -- cannot read them.

--
~Randy