Re: [PATCH] ncurses based config V2

Nir Tzachar
2008-11-25T12:35:38Z

Hi.

On Tue, Nov 25, 2008 at 10:11 AM, Sam Ravnborg <sam@ravnborg.org> wrote:
> Hi Nir.
>
>> >> [ ] (U)TS namespace
>> >> [ ] (I)PC namespace
>> >> [ ] (U)ser namespace (EXPERIMENTAL)
>> >> [ ] (P)ID Namespaces (EXPERIMENTAL)
>> >
>> > This looks like some ancient stuff and it must be a better way to
>> > show the short-cuts.
>>
>> This was the best I could come up with, as ncurses does not let you
>> use color attributed for menu items. I'll try a different scheme,
>> where the first capitalized letter is the shortcut. What do u say?
>
> Better than the above - let me see it in action and I will judge.
> I had preferred something with a colored highlight - but if ncurses
> do not support that then I think first catital letter i ok.
>
> Alternative is to use first letter in the prompt and accept the
> ambiguity.
>

There is too much ambiguity here -- what if the first letter is 'm'?
or 'n'? you have problems then.

>> > I would really appreciate if you could look into the above issues.
>> > If you do a repost with this fixed I will try to do a proper review,
>> > including code-review next time.
>>
>> Sure. I'll have a patch ready in a few days.
>
> Great - loks forward to see it.
>
> Sam
>