public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Andrey Borzenkov <arvidjaar@mail.ru>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-kbuild@vger.kernel.org
Subject: Re: Building two (external) modules from the same sources
Date: Tue, 30 Sep 2008 20:19:07 -0700	[thread overview]
Message-ID: <20081001031907.GA19181@kroah.com> (raw)
In-Reply-To: <200809290949.35749.arvidjaar@mail.ru>

On Mon, Sep 29, 2008 at 09:49:34AM +0400, Andrey Borzenkov wrote:
> I have here driver that can be built for two different types of
> hardware from basically the same sources (this is port of old Agere
> drivers for Hermes-I/Hermes-II chipsets).

Cool, do you have a link to the code, I'd be glad to add it to
drivers/staging/ if it's not in a fully-mergable state yet to get wider
users for it.

> Build differs only in one define -DHERMES2 and single file with
> different firmware. Unfortunately "if HII" are spread over sources
> which makes splitting of sources rather questionable.
> 
> What is the best way (from kbuild POV) to build two modules - for H-I
> and H-II - from the same set of source files?

Not to create two different modules, but rather have one module that
works for both pieces of hardware, with dynamic checks for the different
portions.

thanks,

greg k-h

  reply	other threads:[~2008-10-01  3:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-29  5:49 Building two (external) modules from the same sources Andrey Borzenkov
2008-10-01  3:19 ` Greg KH [this message]
2008-10-01 10:13   ` Andrey Borzenkov
2008-10-01 20:05     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081001031907.GA19181@kroah.com \
    --to=greg@kroah.com \
    --cc=arvidjaar@mail.ru \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox