Building two (external) modules from the same sources

Building two (external) modules from the same sources

[Andrey Borzenkov]

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

I have here driver that can be built for two different types of
hardware from basically the same sources (this is port of old Agere
drivers for Hermes-I/Hermes-II chipsets). Build differs only in one
define -DHERMES2 and single file with different firmware. Unfortunately
"if HII" are spread over sources which makes splitting of sources rather
questionable.

What is the best way (from kbuild POV) to build two modules - for H-I
and H-II - from the same set of source files?

TIA

-andrey

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: Building two (external) modules from the same sources

[Greg KH]

On Mon, Sep 29, 2008 at 09:49:34AM +0400, Andrey Borzenkov wrote:
> I have here driver that can be built for two different types of
> hardware from basically the same sources (this is port of old Agere
> drivers for Hermes-I/Hermes-II chipsets).

Cool, do you have a link to the code, I'd be glad to add it to
drivers/staging/ if it's not in a fully-mergable state yet to get wider
users for it.

> Build differs only in one define -DHERMES2 and single file with
> different firmware. Unfortunately "if HII" are spread over sources
> which makes splitting of sources rather questionable.
> 
> What is the best way (from kbuild POV) to build two modules - for H-I
> and H-II - from the same set of source files?

Not to create two different modules, but rather have one module that
works for both pieces of hardware, with dynamic checks for the different
portions.

thanks,

greg k-h

Re: Building two (external) modules from the same sources

[Andrey Borzenkov]

[-- Attachment #1.1: Type: text/plain, Size: 1846 bytes --]

On Wednesday 01 October 2008, Greg KH wrote:
> On Mon, Sep 29, 2008 at 09:49:34AM +0400, Andrey Borzenkov wrote:
> > I have here driver that can be built for two different types of
> > hardware from basically the same sources (this is port of old Agere
> > drivers for Hermes-I/Hermes-II chipsets).
> 
> Cool, do you have a link to the code, I'd be glad to add it to
> drivers/staging/ if it's not in a fully-mergable state yet to get wider
> users for it.
> 

You can look at it here: http://arvidjaar.newmail.ru/wlags49.tar.bz

I doubt that it is suitable for inclusion at current state if ever.
This is taken directly from Agere 2.4 sources; the only parts that were
touched are kernel glue and wireless extensions interface.

And it is not GPL'ed, of course. I attach E-Mail I received a while
back with answere from Agere legal department.

I know that (rather unexpectedly) driver got some acceptance and I was
approached several times by different people; I Cc to them.

> > Build differs only in one define -DHERMES2 and single file with
> > different firmware. Unfortunately "if HII" are spread over sources
> > which makes splitting of sources rather questionable.
> > 
> > What is the best way (from kbuild POV) to build two modules - for H-I
> > and H-II - from the same set of source files?
> 
> Not to create two different modules, but rather have one module that
> works for both pieces of hardware, with dynamic checks for the different
> portions.
> 

I can't; one of the reasons being - I have no idea how to do it. Original
sources build separate modules for every flavour of driver. It is just that
I was recently asked about this driver on Zaurus (which happens to use
Hermes-II); so I had to do something about it.

If someone could offer (link to) hermes-1/2 programming manual ...

[-- Attachment #1.2: TJ <tj@tjworld.net>: Re: wlags49_h1_cs - 2.6.x - Agere Hermes I driver --]
[-- Type: message/rfc822, Size: 2696 bytes --]

From: TJ <tj@tjworld.net>
To: Andrey Borzenkov <arvidjaar@mail.ru>
Subject: Re: wlags49_h1_cs - 2.6.x - Agere Hermes I driver
Date: Mon, 05 Feb 2007 19:28:59 +0000
Message-ID: <1170703739.10363.9.camel@butch.lan.tjworld.net>

Hi Andrey,

I've got some good news for you/us/the world of Hermes :)

I got a reply from the legal representative at Agere confirming that
their source-code is BSD licensed, and I've included the contents of the
email here.

I hope this re-assures you so that your excellent work on the drivers
can be made widely available for other hackers to work with.

Regards,

TJ.

---------
On Mon, 2007-02-05 at 13:54 -0500, Pathare, Viren M (Viren) wrote:


"I would like to confirm that the two drivers; Linux LKM Wireless Driver
Source Code, Version 7.18 and Linux LKM Wireless Driver Source Code,
Version 7.22 comply with Open Source BSD License. Therefore the source
code can be distributed in unmodified or modified form consistent with
the terms of the license.

The Linux driver architecture was based on two modules, the MSF (Module
specific functions) and the HCF (Hardware Control Functions).  Included
in the HCF is run-time firmware (binary format) which is downloaded into
the RAM of the Hermes 1/2/2.5 WMAC.

This hex coded firmware is not based on any open source software and
hence it is not subject to any Open Source License.  The firmware was
developed by Agere and runs on the DISC processor embedded within the
Hermes 1/2/2.5 Wireless MAC devices. 

Hope this helps.

Sincerely,

Viren Pathare
Intellectual Property Licensing Manager
Agere"



[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: Building two (external) modules from the same sources

[Greg KH]

On Wed, Oct 01, 2008 at 02:13:10PM +0400, Andrey Borzenkov wrote:
> On Wednesday 01 October 2008, Greg KH wrote:
> > On Mon, Sep 29, 2008 at 09:49:34AM +0400, Andrey Borzenkov wrote:
> > > I have here driver that can be built for two different types of
> > > hardware from basically the same sources (this is port of old Agere
> > > drivers for Hermes-I/Hermes-II chipsets).
> > 
> > Cool, do you have a link to the code, I'd be glad to add it to
> > drivers/staging/ if it's not in a fully-mergable state yet to get wider
> > users for it.
> > 
> 
> You can look at it here: http://arvidjaar.newmail.ru/wlags49.tar.bz
> 
> I doubt that it is suitable for inclusion at current state if ever.
> This is taken directly from Agere 2.4 sources; the only parts that were
> touched are kernel glue and wireless extensions interface.

It is acceptable for inclusion in drivers/staging/ where we can work on
cleaning it up from within the kernel environment, and provide access to
users who are wanting to use these drivers now.

Is it ok if I add it there?  I'll take the above tarball and make up the
proper patch and get it to build.

> And it is not GPL'ed, of course. I attach E-Mail I received a while
> back with answere from Agere legal department.

It's BSD, which is fine, that works with the GPLv2 license of the rest
of the kernel.

> > > Build differs only in one define -DHERMES2 and single file with
> > > different firmware. Unfortunately "if HII" are spread over sources
> > > which makes splitting of sources rather questionable.
> > > 
> > > What is the best way (from kbuild POV) to build two modules - for H-I
> > > and H-II - from the same set of source files?
> > 
> > Not to create two different modules, but rather have one module that
> > works for both pieces of hardware, with dynamic checks for the different
> > portions.
> > 
> 
> I can't; one of the reasons being - I have no idea how to do it. Original
> sources build separate modules for every flavour of driver. It is just that
> I was recently asked about this driver on Zaurus (which happens to use
> Hermes-II); so I had to do something about it.

Hm, I'll look at the code and see if I see anything obvious.

> If someone could offer (link to) hermes-1/2 programming manual ...

That would probably help out a lot :)

thanks,

greg k-h