Re: KBUILD: do not include arch/<ARCH>/include/asm in find-sources twice.

[Sam Ravnborg <sam@ravnborg.org>]

On Tue, Oct 28, 2008 at 01:36:25PM +0000, Ian Campbell wrote:
> Architectures which have moved their includes to arch/<ARCH>/include
> now list the headers twice in the source listing used by "make
> cscope" and friends, causing those tools to list symbols twice.
> 
> Skipping these files in the ALLSOURCE_ARCHS pass rather than removing
> the ALLINCLUDE_ARCHS pass preserves the semantics of the later.
> 
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: linux-kbuild@vger.kernel.org
> 
> diff -r a613b893f5b5 Makefile
> --- a/Makefile	Mon Oct 27 10:29:49 2008 +0000
> +++ b/Makefile	Tue Oct 28 13:33:04 2008 +0000
> @@ -1435,7 +1435,8 @@
>  define find-sources
>          ( for arch in $(ALLSOURCE_ARCHS) ; do \
>  	       find $(__srctree)arch/$${arch} $(RCS_FIND_IGNORE) \
> -	            -name $1 -print; \
> +		    -wholename $(__srctree)arch/$${arch}/include/asm -type d -prune \
> +	            -o -name $1 -print; \
>  	  done ; \
>  	  find $(__srctree)security/selinux/include $(RCS_FIND_IGNORE) \
>  	       -name $1 -print; \
> 

Hi Ian.

I would much rather prefer to see a patch that
- support the platforms of arm and others
- uses the fact that all arch have their header files moved
  to arch/$ARCH/include
  [Ignore the archs that are lacking behind]

And if we could simplify this "find file" list on top of that it would be extra bonus.

	Sam