* [patch 03/13] lkdtm: fix for CONFIG_SCSI=n
@ 2008-10-29 21:20 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2008-10-29 21:20 UTC (permalink / raw)
To: sam; +Cc: linux-kbuild, akpm, randy.dunlap, ankita
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix lkdtm test code for case of CONFIG_SCSI=n, to avoid build errors:
In file included from linux-next-20080618/tests/lkdtm.c:55:
linux-next-20080618/include/scsi/scsi_cmnd.h:28:25: warning: "BLK_MAX_CDB" is not defined
linux-next-20080618/include/scsi/scsi_cmnd.h:29:3: error: #error MAX_COMMAND_SIZE can not be bigger than BLK_MAX_CDB
In file included from linux-next-20080618/tests/lkdtm.c:55:
linux-next-20080618/include/scsi/scsi_cmnd.h: In function 'scsi_bidi_cmnd':
linux-next-20080618/include/scsi/scsi_cmnd.h:183: error: implicit declaration of function 'blk_bidi_rq'
linux-next-20080618/include/scsi/scsi_cmnd.h:184: error: dereferencing pointer to incomplete type
linux-next-20080618/include/scsi/scsi_cmnd.h: In function 'scsi_in':
linux-next-20080618/include/scsi/scsi_cmnd.h:190: error: dereferencing pointer to incomplete type
make[2]: *** [tests/lkdtm.o] Error 1
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Ankita Garg <ankita@in.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
tests/lkdtm.c | 6 ++++++
1 file changed, 6 insertions(+)
diff -puN tests/lkdtm.c~lkdtm-fix-for-config_scsi=n tests/lkdtm.c
--- a/tests/lkdtm.c~lkdtm-fix-for-config_scsi=n
+++ a/tests/lkdtm.c
@@ -175,12 +175,14 @@ static int jp_hrtimer_start(struct hrtim
return 0;
}
+#ifdef CONFIG_SCSI
static int jp_scsi_dispatch_cmd(struct scsi_cmnd *cmd)
{
lkdtm_handler();
jprobe_return();
return 0;
}
+#endif
#ifdef CONFIG_IDE
int jp_generic_ide_ioctl(ide_drive_t *drive, struct file *file,
@@ -307,8 +309,12 @@ static int __init lkdtm_module_init(void
lkdtm.entry = (kprobe_opcode_t*) jp_hrtimer_start;
break;
case SCSI_DISPATCH_CMD:
+#ifdef CONFIG_SCSI
lkdtm.kp.symbol_name = "scsi_dispatch_cmd";
lkdtm.entry = (kprobe_opcode_t*) jp_scsi_dispatch_cmd;
+#else
+ printk(KERN_INFO "lkdtm : Crash point not available\n");
+#endif
break;
case IDE_CORE_CP:
#ifdef CONFIG_IDE
_
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-10-29 21:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-29 21:20 [patch 03/13] lkdtm: fix for CONFIG_SCSI=n akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox