From: Sam Ravnborg <sam@ravnborg.org>
To: Ian Campbell <ijc@hellion.org.uk>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: KBUILD: do not include arch/<ARCH>/include/asm in find-sources twice.
Date: Wed, 29 Oct 2008 22:29:28 +0100 [thread overview]
Message-ID: <20081029212928.GA24474@uranus.ravnborg.org> (raw)
In-Reply-To: <1225309873.5267.10.camel@localhost.localdomain>
On Wed, Oct 29, 2008 at 07:51:13PM +0000, Ian Campbell wrote:
> On Wed, 2008-10-29 at 20:07 +0100, Sam Ravnborg wrote:
> > On Tue, Oct 28, 2008 at 01:36:25PM +0000, Ian Campbell wrote:
> > > Architectures which have moved their includes to arch/<ARCH>/include
> > > now list the headers twice in the source listing used by "make
> > > cscope" and friends, causing those tools to list symbols twice.
> > >
> > > Skipping these files in the ALLSOURCE_ARCHS pass rather than removing
> > > the ALLINCLUDE_ARCHS pass preserves the semantics of the later.
> > >
> > > Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> > > Cc: Sam Ravnborg <sam@ravnborg.org>
> > > Cc: linux-kbuild@vger.kernel.org
> > >
> > > diff -r a613b893f5b5 Makefile
> > > --- a/Makefile Mon Oct 27 10:29:49 2008 +0000
> > > +++ b/Makefile Tue Oct 28 13:33:04 2008 +0000
> > > @@ -1435,7 +1435,8 @@
> > > define find-sources
> > > ( for arch in $(ALLSOURCE_ARCHS) ; do \
> > > find $(__srctree)arch/$${arch} $(RCS_FIND_IGNORE) \
> > > - -name $1 -print; \
> > > + -wholename $(__srctree)arch/$${arch}/include/asm -type d -prune \
> > > + -o -name $1 -print; \
> > > done ; \
> > > find $(__srctree)security/selinux/include $(RCS_FIND_IGNORE) \
> > > -name $1 -print; \
> > >
> >
> > Hi Ian.
> >
> > I would much rather prefer to see a patch that
> > - support the platforms of arm and others
>
> How do you mean?
>
> $ ls arch/arm/include/
> asm/
>
> so it'll work as well for arm as it does for any other architecture.
fyi - I have applied your patch to kbuild-fixes.
I hope this stuff can be simplified one day.
I continue to see a steady stream of patches dealing with tags and cscope.
Maybe the right thing to do is to just move it all out in a shell
script so we do not clutter the makefile with all this.
Sam
next prev parent reply other threads:[~2008-10-29 21:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 13:36 KBUILD: do not include arch/<ARCH>/include/asm in find-sources twice Ian Campbell
2008-10-29 19:07 ` Sam Ravnborg
2008-10-29 19:51 ` Ian Campbell
2008-10-29 21:29 ` Sam Ravnborg [this message]
2008-10-30 11:02 ` Ian Campbell
2008-10-30 11:09 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081029212928.GA24474@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=ijc@hellion.org.uk \
--cc=linux-kbuild@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox