public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Nir Tzachar <nir.tzachar@gmail.com>
Cc: Willy Tarreau <w@1wt.eu>,
	Nir Tzachar <tzachar@grad120a.cs.bgu.ac.il>,
	linux-kernel@vger.kernel.org, bzolnier@gmail.com,
	zippel@linux-m68k.org, linux-kbuild@vger.kernel.org,
	ariveira@gmail.com, rdunlap@xenotime.net,
	kosaki.motohiro@jp.fujitsu.com, 7eggert@gmx.de
Subject: Re: [PATCH] ncurses based config V2
Date: Tue, 25 Nov 2008 09:11:53 +0100	[thread overview]
Message-ID: <20081125081153.GA12275@uranus.ravnborg.org> (raw)
In-Reply-To: <9b2db90b0811250001k6e0c609frca073f3221a3e8ed@mail.gmail.com>

Hi Nir.

> >>         [ ]   (U)TS namespace
> >>         [ ]   (I)PC namespace
> >>         [ ]   (U)ser namespace (EXPERIMENTAL)
> >>         [ ]   (P)ID Namespaces (EXPERIMENTAL)
> >
> > This looks like some ancient stuff and it must be a better way to
> > show the short-cuts.
> 
> This was the best I could come up with, as ncurses does not let you
> use color attributed for menu items. I'll try a different scheme,
> where the first capitalized letter is the shortcut. What do u say?

Better than the above - let me see it in action and I will judge.
I had preferred something with a colored highlight - but if ncurses
do not support that then I think first catital letter i ok.

Alternative is to use first letter in the prompt and accept the
ambiguity.

> > I would really appreciate if you could look into the above issues.
> > If you do a repost with this fixed I will try to do a proper review,
> > including code-review next time.
> 
> Sure. I'll have a patch ready in a few days.

Great - loks forward to see it.

	Sam

  reply	other threads:[~2008-11-25  8:10 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-03 19:11 [PATCH] ncurses based config Nir Tzachar
2008-09-03 19:38 ` Bartlomiej Zolnierkiewicz
2008-09-03 20:02   ` Randy.Dunlap
2008-09-03 20:03     ` Randy.Dunlap
2008-09-03 20:18     ` Bartlomiej Zolnierkiewicz
2008-09-03 20:29     ` Alejandro Riveira Fernández
2008-09-04 15:02       ` Bartlomiej Zolnierkiewicz
     [not found]     ` <9b2db90b0809032155h6ed5df9ey846de96779022d11@mail.gmail.com>
2008-09-04 15:28       ` Randy.Dunlap
2008-09-04  4:22 ` KOSAKI Motohiro
2008-09-04 10:36 ` Alejandro Riveira Fernández
2008-09-05  8:27 ` [PATCH] ncurses based config V2 Nir Tzachar
2008-09-05 13:49   ` Alejandro Riveira Fernández
2008-09-05 19:59   ` Willy Tarreau
2008-09-06  5:41     ` Nir Tzachar
2008-09-14 10:52       ` Willy Tarreau
2008-09-17 11:58         ` Nir Tzachar
2008-11-24 18:44     ` Sam Ravnborg
2008-11-25  2:33       ` Roman Zippel
2008-11-25  8:04         ` Nir Tzachar
2008-11-25 16:02           ` Roman Zippel
2008-11-25  8:01       ` Nir Tzachar
2008-11-25  8:11         ` Sam Ravnborg [this message]
2008-11-25 12:35           ` Nir Tzachar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081125081153.GA12275@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=7eggert@gmx.de \
    --cc=ariveira@gmail.com \
    --cc=bzolnier@gmail.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nir.tzachar@gmail.com \
    --cc=rdunlap@xenotime.net \
    --cc=tzachar@grad120a.cs.bgu.ac.il \
    --cc=w@1wt.eu \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox