Re: [PATCH 04/26] kbuild: introduce $(kecho) convenience echo

Randy Dunlap
2008-12-22T18:49:47Z

On Sat, 20 Dec 2008 15:31:15 +0100 Sam Ravnborg wrote:

> From: Mike Frysinger <vapier@gentoo.org>
>
> There is a bunch of places in the build system where we do 'echo' to show
> some nice status lines. This means we still get output when running in
> silent mode. So declare a new KECHO variable that only does 'echo' when we
> are in a suitable verbose build mode.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> [sam: added Documentation]
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>

Hi,
Just nits/clarifications (below).

> ---
> Documentation/kbuild/makefiles.txt | 14 ++++++++++++++
> scripts/Kbuild.include | 7 +++++++
> 2 files changed, 21 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/kbuild/makefiles.txt b/Documentation/kbuild/makefiles.txt
> index 7a77533..51104f9 100644
> --- a/Documentation/kbuild/makefiles.txt
> +++ b/Documentation/kbuild/makefiles.txt
> @@ -383,6 +383,20 @@ more details, with real examples.
> to prerequisites are referenced with $(src) (because they are not
> generated files).
>
> + $(kecho)
> + echoing information to user in a rule is often a good practice

to users

> + but when execution "make -s" one does not expect to see any output

executing

> + except for warnings/errors.
> + To support this kbuild define $(kecho) which will echo out the

defines

> + text following $(kecho) to stdout except if "make -s" is used.

s/except if/unless/

> +
> + Example:
> + #arch/blackfin/boot/Makefile
> + $(obj)/vmImage: $(obj)/vmlinux.gz
> + $(call if_changed,uimage)
> + @$(kecho) 'Kernel: $@ is ready'
> +
> +
> --- 3.11 $(CC) support functions
>
> The kernel may be built with several different versions of

---
~Randy