From: Jiri Slaby <jirislaby@kernel.org>
To: Michael Matz <matz@suse.de>
Cc: "Masahiro Yamada" <masahiroy@kernel.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Martin Liška" <mliska@suse.cz>,
"Borislav Petkov" <bpetkov@suse.de>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ard Biesheuvel" <ardb@kernel.org>
Subject: Re: [PATCH v3 6/7] kbuild: use obj-y instead extra-y for objects placed at the head
Date: Wed, 26 Oct 2022 10:35:45 +0200 [thread overview]
Message-ID: <2008526a-e0ca-7e67-cff6-b540d62e58c7@kernel.org> (raw)
In-Reply-To: <alpine.LSU.2.20.2210251210140.29399@wotan.suse.de>
On 25. 10. 22, 14:26, Michael Matz wrote:
>> Ideas, comments? I'll send the attachment as a PATCH later (if there are
>> no better suggestions).
>
> This will work. An alternative way would be to explicitly name the input
> file in the section commands, without renaming the section:
>
> @@ -126,6 +126,7 @@ SECTIONS
> _text = .;
> _stext = .;
> /* bootstrapping code */
> + KEEP(vmlinux.a:head64.o(.head.text))
> HEAD_TEXT
> TEXT_TEXT
>
> But I guess not all arch's name their must-be-first file head64.o (or even
> have such requirement), so that's probably still arch-dependend and hence
> not inherently better than your way.
The downside of this is that it doesn't make sure the function
(startup_64()) is the first one. When someone sticks something before
it, it breaks again. But leaving the decision up to the x86 maintainers ;).
Re. other archs, I have absolutely no idea (haven't looked into that at
all).
thanks,
--
js
next prev parent reply other threads:[~2022-10-26 8:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-24 18:19 [PATCH v3 0/7] kbuild: various cleanups Masahiro Yamada
2022-09-24 18:19 ` [PATCH v3 1/7] kbuild: hard-code KBUILD_ALLDIRS in scripts/Makefile.package Masahiro Yamada
2022-09-28 19:09 ` Nicolas Schier
2022-09-24 18:19 ` [PATCH v3 2/7] kbuild: list sub-directories in ./Kbuild Masahiro Yamada
2022-09-24 19:37 ` kernel test robot
2022-09-24 20:27 ` kernel test robot
2022-09-25 0:28 ` Masahiro Yamada
2022-09-26 21:06 ` Nick Desaulniers
2022-09-28 8:32 ` Masahiro Yamada
2022-09-28 19:30 ` Nicolas Schier
2022-09-24 18:19 ` [PATCH v3 3/7] kbuild: move .vmlinux.objs rule to Makefile.modpost Masahiro Yamada
2022-09-28 19:35 ` Nicolas Schier
2022-09-24 18:19 ` [PATCH v3 4/7] kbuild: move vmlinux.o rule to the top Makefile Masahiro Yamada
2022-09-28 19:37 ` Nicolas Schier
2022-09-24 18:19 ` [PATCH v3 5/7] kbuild: unify two modpost invocations Masahiro Yamada
2022-09-28 19:59 ` Nicolas Schier
2022-09-28 21:05 ` Masahiro Yamada
2022-09-24 18:19 ` [PATCH v3 6/7] kbuild: use obj-y instead extra-y for objects placed at the head Masahiro Yamada
2022-09-28 20:15 ` Nicolas Schier
2022-10-24 18:24 ` Jiri Slaby
2022-10-25 12:26 ` Michael Matz
2022-10-26 8:35 ` Jiri Slaby [this message]
2022-10-26 11:20 ` Ard Biesheuvel
2022-10-26 16:29 ` Masahiro Yamada
2022-10-26 17:09 ` Michael Matz
2022-09-24 18:19 ` [PATCH v3 7/7] kbuild: remove head-y syntax Masahiro Yamada
2022-09-29 15:21 ` Nicolas Schier
2022-10-18 8:16 ` Jiri Slaby
2022-10-18 9:12 ` Masahiro Yamada
2022-09-26 21:39 ` [PATCH v3 0/7] kbuild: various cleanups Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2008526a-e0ca-7e67-cff6-b540d62e58c7@kernel.org \
--to=jirislaby@kernel.org \
--cc=ardb@kernel.org \
--cc=bpetkov@suse.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=matz@suse.de \
--cc=mliska@suse.cz \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox