From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pfepb.post.tele.dk ([195.41.46.236]:49462 "EHLO pfepb.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752940AbZAIUDg (ORCPT ); Fri, 9 Jan 2009 15:03:36 -0500 Date: Fri, 9 Jan 2009 21:05:14 +0100 From: Sam Ravnborg Subject: Re: [PATCH 1/6]Make recordmcount destinct module compile Message-ID: <20090109200514.GA24634@uranus.ravnborg.org> References: <1231468368.10683.100.camel@sli10-desk.sh.intel.com> <20090109192841.GA19482@uranus.ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Steven Rostedt Cc: Shaohua Li , ia64 , "Luck, Tony" , Ingo Molnar , linux-kbuild@vger.kernel.org On Fri, Jan 09, 2009 at 02:57:38PM -0500, Steven Rostedt wrote: > > On Fri, 9 Jan 2009, Sam Ravnborg wrote: > > So we duplicate the cases where we identify "this .o file > > is used in a module". > > This is not good. > > > > Also there is no reason to do this for the .i, .s and .lst > > targets as they do not invode recordmcount.pl anyway. > > > > If your build your patch on top of the following we avoid > > the duplicated list. > > > > Sam > > Thanks Sam, > > Can I add this on top of Shaohua's and put your Signed-off-by, as well > as an Acked-by on Shaohua's? My patch was made on top of -linus so you need to use the flag in the call to recordmount.pl. Please feel free to put my Acked-by: on the patch, but as this does not originate from me it would be the wrong documentation trail to add my Sigend-off-by as I just gave an improvement proposal. Sam