From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from casper.infradead.org ([85.118.1.10]:58389 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755488AbZARVG6 (ORCPT ); Sun, 18 Jan 2009 16:06:58 -0500 Date: Sun, 18 Jan 2009 13:09:08 -0800 From: Arjan van de Ven Subject: Re: [PATCH] Compress kernel modules on installation. Message-ID: <20090118130908.390eb07b@infradead.org> In-Reply-To: <20090118210416.GE2978@uranus.ravnborg.org> References: <20080225214209.a3f79327.sbrokenshire@xestia.co.uk> <20080226112840.GA29465@uranus.ravnborg.org> <20081226194833.GA8306@uranus.ravnborg.org> <20090118210416.GE2978@uranus.ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Sam Ravnborg Cc: Jan Engelhardt , Steve Brokenshire , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org On Sun, 18 Jan 2009 22:04:16 +0100 Sam Ravnborg wrote: > On Fri, Dec 26, 2008 at 08:50:34PM +0100, Jan Engelhardt wrote: > > > > On Friday 2008-12-26 20:48, Sam Ravnborg wrote: > > >> >> > > >> >> This patch allows kernel modules to be compressed when 'make > > >> >> modules_install' is run after being copied to > > >> >> the /lib/module//<...> directory which is useful if > > >> >> you have module-init-tools installed with --enable-zlib. This > > >> >> patch adds an option (MODULE_COMPRESS) to the kernel > > >> >> configuration file (specifically init/Kconfig) so that the > > >> >> kernel modules will compressed if MODULE_COMPRESS is set. > > >> > > >> I recently started compressing my kernel modules and that saved > > >> me at least 70 MB of disk space on mostlyallmodconfig. > > >> (And no, the argument of disks being cheap is not so true with > > >> CF or SSD.) > > >> Distro is lazy and wants to wait for upstream to have it, > > >> so is there any chance of getting this proposal in? > > > > > >Steve said he wanted to try to make the solution more > > >scalable so I am awaiting a new patch. > > > > Hm, all I needed was this patch. It might fire up some people, > > but it's got all the scalability I could think of.. > > Can I ask you to redo this patch. > I want a way to swith off compression, but it should default be > enable. So if KBUILD_MODULE_NOCOMPRESS is undefined we will compress > the modules when we install them. > especially since the decompression is an option for the module tools, it should be an option for the kernel... since it does add a dependency for the module tools (and one that you might not need; for example I disabled it just to remove a build requires) -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org