From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:51474 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbZBUF6z (ORCPT ); Sat, 21 Feb 2009 00:58:55 -0500 Date: Fri, 20 Feb 2009 21:58:00 -0800 From: Andrew Morton Subject: Re: [PATCH][RFC] check for select dependency errors on config load Message-Id: <20090220215800.1a009182.akpm@linux-foundation.org> In-Reply-To: References: <499edf47.1818d00a.060b.2b8d@mx.google.com> <499EE162.4050008@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Steven Rostedt Cc: LKML , linux-kbuild@vger.kernel.org, Randy Dunlap , Frederic Weisbecker , Ingo Molnar , zippel@linux-m68k.org, Sam Ravnborg On Sat, 21 Feb 2009 00:24:05 -0500 (EST) Steven Rostedt wrote: > There's been a few problems with SELECT and dependencies lately. > I've been burnt by it a few times myself. So I look at the kconfig > code and added this patch. It can use a bit more work but it does what > I want. > > When the config is loaded, it checks all the symbols that are > selected by an active config and makes sure the visible dependencies are > also activated. This should probably be moved to the writing of the > config instead, but since I just wanted to see if my current config was > OK, I did it on load. This is an RFC patch anyway, so fixes/comments are > definitely welcome. > > Here's what I get with the attached config running on 2.6.29-rc5. > > $ make menuconfig > scripts/kconfig/mconf arch/x86/Kconfig > .config:2561:warning: MICROCODE selects FW_LOADER which fails its dependencies! > .config:2561:warning: MICROCODE_INTEL selects FW_LOADER which fails its dependencies! > .config:2561:warning: PCMCIA_LOAD_CIS selects FW_LOADER which fails its dependencies! > .config:2561:warning: SCSI_SAS_LIBSAS selects SCSI_SAS_ATTRS which fails its dependencies! > .config:2561:warning: SCSI_AIC94XX selects FW_LOADER which fails its dependencies! > .config:2561:warning: KEYBOARD_ATKBD selects SERIO which fails its dependencies! > .config:2561:warning: KEYBOARD_ATKBD selects SERIO_LIBPS2 which fails its dependencies! > .config:2561:warning: KEYBOARD_ATKBD selects SERIO_I8042 which fails its dependencies! > .config:2561:warning: MOUSE_PS2 selects SERIO which fails its dependencies! > .config:2561:warning: MOUSE_PS2 selects SERIO_LIBPS2 which fails its dependencies! > .config:2561:warning: MOUSE_PS2 selects SERIO_I8042 which fails its dependencies! > .config:2561:warning: VT selects INPUT which fails its dependencies! > .config:2561:warning: DRM selects I2C_ALGOBIT which fails its dependencies! > .config:2561:warning: SND_EMU10K1 selects FW_LOADER which fails its dependencies! Well damn, that looks like a major contribution to the general well-being. Sam, could you please give this a scan and merge it into linux-next via your tree? I wonder how hard it would be to print out the reason why (for example) FW_LOADER failed its dependencies?