Re: [PATCH] tracing/markers: make markers select tracepoints

Frank Ch. Eigler
2009-02-22T17:38:20Z

Hi -

On Sun, Feb 22, 2009 at 06:13:44PM +0100, Ingo Molnar wrote:
> [...]
> > It would be even easier converted to the markers API directly,
> > without the KVMTRACE* macro intermediary:
> >
> > before:
> > KVMTRACE_3D(MSR_READ, &svm->vcpu, ecx, (u32)data,
> > (u32)(data >> 32), handler);
> > after:
> > trace_mark(kvmtrace, "MSR_READ: %p, %08lx, %016Lx\n",
> > &svm->vcpu, ecx, data);
> >
> > All this already "just works".
> except that we are removing markers.

Perhaps that intention should be justified and reexamined, especially
considering the KVMTRACE* macro-replacement solution you suggested is
almost the same.

- FChE