From: Sam Ravnborg <sam@ravnborg.org>
To: linux-kbuild <linux-kbuild@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: Roman Zippel <zippel@linux-m68k.org>, Ingo Molnar <mingo@elte.hu>
Subject: kconfig - fix randconfig
Date: Sun, 15 Mar 2009 11:23:41 +0100 [thread overview]
Message-ID: <20090315102341.GA6051@uranus.ravnborg.org> (raw)
kconfig failed to generate random values for choice values in
a choice block thus limiting the effect of builds based on randconfig
generated configs.
To test this I used this small config:
config MOD
def_bool n
option modules
choice CHOICE
prompt "ABCD Choice"
default A
config A
tristate "A"
config B
tristate "B"
config C
tristate "C"
config D
tristate "D"
endchoice
With the fix applied we now distribute the values more or
less even among the choice symbols.
And if MOD is enabled then we have several entries enabled.
Furhtermore calling randconfig several times in row made it
generate the same config as it used a second based seed.
Two patches follows - they are also at kfixes.git
Sam
next reply other threads:[~2009-03-15 10:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-15 10:23 Sam Ravnborg [this message]
2009-03-15 10:28 ` [PATCH 1/2] kconfig: fix randconfig for choice blocks Sam Ravnborg
2009-03-15 10:28 ` [PATCH 2/2] kconfig: improve seed in randconfig Sam Ravnborg
2009-03-15 10:53 ` Geert Uytterhoeven
2009-03-15 13:09 ` Sam Ravnborg
2009-03-15 18:54 ` Ingo Molnar
2009-03-15 21:47 ` Alexander van Heukelum
2009-03-15 22:03 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090315102341.GA6051@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox