[PATCH] headerdep: fix option processing for -I

[PATCH] headerdep: fix option processing for -I

[Uwe Kleine-König]

-I takes an argument.  Without this change only a 1 is added to
@opt_include which is not helpful.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>

---
 scripts/headerdep.pl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/headerdep.pl b/scripts/headerdep.pl
index 97399da..536408e 100755
--- a/scripts/headerdep.pl
+++ b/scripts/headerdep.pl
@@ -19,7 +19,7 @@ my $opt_graph;
 	version	=> \&version,
 
 	all	=> \$opt_all,
-	I	=> \@opt_include,
+	"I:s"	=> \@opt_include,
 	graph	=> \$opt_graph,
 );
 
-- 
tg: (5d80f8e..) t/misc/fix_include_opt_for_headerdep (depends on: linus/master)

Re: [PATCH] headerdep: fix option processing for -I

[Vegard Nossum]

2009/3/29 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> -I takes an argument.  Without this change only a 1 is added to
> @opt_include which is not helpful.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Vegard Nossum <vegard.nossum@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
>
> ---
>  scripts/headerdep.pl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/headerdep.pl b/scripts/headerdep.pl
> index 97399da..536408e 100755
> --- a/scripts/headerdep.pl
> +++ b/scripts/headerdep.pl
> @@ -19,7 +19,7 @@ my $opt_graph;
>        version => \&version,
>
>        all     => \$opt_all,
> -       I       => \@opt_include,
> +       "I:s"   => \@opt_include,
>        graph   => \$opt_graph,
>  );

Thanks!

Acked-by: Vegard Nossum <vegard.nossum@gmail.com>


Vegard

Re: [PATCH] headerdep: fix option processing for -I

[Uwe Kleine-König]

Hello,

sorry for replying to my own mail, but I found a further enhancement.

On Sun, Mar 29, 2009 at 03:01:47PM +0200, Uwe Kleine-König wrote:
> -I takes an argument.  Without this change only a 1 is added to
> @opt_include which is not helpful.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Vegard Nossum <vegard.nossum@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> 
> ---
>  scripts/headerdep.pl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/headerdep.pl b/scripts/headerdep.pl
> index 97399da..536408e 100755
> --- a/scripts/headerdep.pl
> +++ b/scripts/headerdep.pl
> @@ -19,7 +19,7 @@ my $opt_graph;
>  	version	=> \&version,
>  
>  	all	=> \$opt_all,
> -	I	=> \@opt_include,
> +	"I:s"	=> \@opt_include,
This should better be "I=s".  The difference is that with : the argument
is optional, with = it is not.

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |

Re: [PATCH] headerdep: fix option processing for -I

[Sam Ravnborg]

On Sun, Mar 29, 2009 at 08:26:17PM +0200, Uwe Kleine-König wrote:
> Hello,
> 
> sorry for replying to my own mail, but I found a further enhancement.
> 
> On Sun, Mar 29, 2009 at 03:01:47PM +0200, Uwe Kleine-König wrote:
> > -I takes an argument.  Without this change only a 1 is added to
> > @opt_include which is not helpful.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > Cc: Vegard Nossum <vegard.nossum@gmail.com>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > 
> > ---
> >  scripts/headerdep.pl |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/scripts/headerdep.pl b/scripts/headerdep.pl
> > index 97399da..536408e 100755
> > --- a/scripts/headerdep.pl
> > +++ b/scripts/headerdep.pl
> > @@ -19,7 +19,7 @@ my $opt_graph;
> >  	version	=> \&version,
> >  
> >  	all	=> \$opt_all,
> > -	I	=> \@opt_include,
> > +	"I:s"	=> \@opt_include,
> This should better be "I=s".  The difference is that with : the argument
> is optional, with = it is not.

Applied with this fix and Vegards ack.

	Sam