Re: Comments on deb-pkg patch series

[maximilian attems <max@stro.at>]

On Wed, Apr 01, 2009 at 07:07:29PM +0200, Frans Pop wrote:
> On Wednesday 01 April 2009, maximilian attems wrote:
> > Sam can you please merge 1-6 of the series as those are not contested.
> > thanks.
> 
> I continue to object to patch 4.

your objection on patch 4 is disregarded.
 
> > the patches were submitted to the relevant subsystem,
> > no need to flood lkml with such.
> 
> However, they are also patches with a fairly general impact that should be 
> reviewed by more people than just the narrow group that is subscribed to 
> kbuild. lkml is the generic list and is often CCed in such cases. AFAIK 
> most kbuild patches go through lkml.
> It's just chance that I saw these and was able to comment.

come on, i pointed out this thread to you.
it is enough to post to relevant maintainer list.
subscribe to linux-fs if you interested in vfs changes and so on..
 
> > > [PATCH 4/7] deb-pkg: Fix Section and Source field
> > >             http://marc.info/?l=linux-kbuild&m=123851275123210&w=2
> > >
> > > I strongly disagree with this patch.
> > >
> > > linux-2.6 is the source package for official Debian kernels and
> > > packages built using deb-pkg are NOT built from that source package.
> > > IMO there's no need to change it (the field is required and thus
> > > cannot simply be dropped). If it does want changing for some reason
> > > I'd suggest "linux-upstream" or similar.
> >
> > no,
> > just checkout linux-2.6 git and you'll get per default a matching
> > linux-2.6 dir, so your arg does not stand.
> 
> That still does not change the fact that when I build directly from git 
> head or whatever other git branch or downloaded upstream source the 
> binary package is *not* built from the linux-2.6 source package.
> 
> Therefore setting source to linux-2.6 is factually incorrect.

no it is not more incorrect then setting to linux.
we don't care about corner cases, but go for the general one:
git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
cd linux-2.6
make <config>
make deb-pkg

it does *not* matter that linux-2.6 happens to be same name
than the debian linux images source package.
 
[ snipping discussion of patch 7 that will get reworked ]

-- 
maks