From: Sam Ravnborg <sam@ravnborg.org>
To: Maxime Bizon <mbizon@freebox.fr>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] fix spurious initramfs rebuild
Date: Fri, 10 Apr 2009 13:24:29 +0200 [thread overview]
Message-ID: <20090410112429.GA22370@uranus.ravnborg.org> (raw)
In-Reply-To: <1234201792.1951.26.camel@sakura.staff.proxad.net>
On Mon, Feb 09, 2009 at 06:49:52PM +0100, Maxime Bizon wrote:
>
> Hello,
>
>
>
> When gen_initramfs_list is used to generate make dependencies, it
> includes symbolic links, for which make tracks the link target. Any
> change to that target will cause an initramfs rebuild, even if the
> symlink points to something outside of the initramfs directory.
>
> If the target happens to be /tmp, the rebuild occurs for each kernel
> build, since gen_initramfs_list uses mktemp...
>
> Proposed way to fix it is to omit symbolic links from generated
> dependencies, but this has a small drawback: changing perm/owner on a
> symlink will go unnoticed.
>
>
> Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
>
> --- linux-2.6.28.4/scripts/gen_initramfs_list.sh.old 2009-02-09 18:22:26.000000000 +0100
> +++ linux-2.6.28.4/scripts/gen_initramfs_list.sh 2009-02-09 18:21:54.000000000 +0100
> @@ -97,7 +97,7 @@
> }
>
> list_parse() {
> - echo "$1 \\"
> + [ ! -L "$1" ] && echo "$1 \\" || :
> }
>
> # for each file print a line in following format
Applied.
Sam
prev parent reply other threads:[~2009-04-10 11:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 17:49 [PATCH] fix spurious initramfs rebuild Maxime Bizon
2009-04-10 11:24 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090410112429.GA22370@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=mbizon@freebox.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox