From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pfepa.post.tele.dk ([195.41.46.235]:34295 "EHLO pfepa.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755359AbZDSG0h (ORCPT ); Sun, 19 Apr 2009 02:26:37 -0400 Date: Sun, 19 Apr 2009 08:28:41 +0200 From: Sam Ravnborg Subject: Re: kbuild - introduce support for subdir-ccflags-y Message-ID: <20090419062841.GA17801@uranus.ravnborg.org> References: <20090418125159.GA23008@uranus.ravnborg.org> <20090418125839.GA3668@flint.arm.linux.org.uk> <20090418150750.GA24059@elte.hu> <20090418180953.GE7148@flint.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Kyle Moffett Cc: Ingo Molnar , linux-kbuild , linux arch , LKML , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "David S. Miller" On Sat, Apr 18, 2009 at 11:17:44PM -0400, Kyle Moffett wrote: > On Sat, Apr 18, 2009 at 2:09 PM, Russell King wrote: > > On Sat, Apr 18, 2009 at 05:07:50PM +0200, Ingo Molnar wrote: > >> * Russell King wrote: > >> > On Sat, Apr 18, 2009 at 02:51:59PM +0200, Sam Ravnborg wrote: > >> > > The typical use cases are an architecture or a subsystem that > >> > > decide to cover all files with -Werror. > >> > > Today alpha, mips and sparc uses -Werror in almost all their > >> > > Makefile - with subdir-ccflag-y it is now simpler to do so > >> > > as only the top-level directories needs to be covered. > >> > > >> > Hmm, this won't make sense for ARM.  We have things like #warning > >> > and deprecated functions in machine specific headers, and adding > >> > -Werror to the whole of arch/arm/ will result in these causing > >> > builds to fail. > >> > >> This is optional - if you dont want it, you dont set it. > > > > Please read _all_ of my mail, particularly the bit where it talks about > > it being useful for a certain subset. > > It's my impression that on x86 it's a config option whether or not to > build with -Werror. You could do the exact same thing with an > internal inverted-logic CONFIG_ARM_ALLOW_WARNINGS option and make all > the boards triggering warnings "select ARM_ALLOW_WARNINGS". Then have > a user-visible config option "ARM_USER_ALLOW_WARNINGS" which also > selects the internal option. That adds some additional kconfig-level > documentation on which subarch combos need some love. Correct - but Russell's original comment was that the subdir-* feature was of no use for arm. And this is correct with the current way the individual directories are specified. If you compare arch/x86/kernel/ and arch/arm/kernel/ you will see that x86 has 3 subdirectories where arm has none. Another measure: Arm has 12 Makefiles outside mach* and plat* where x86 has 24 Makefiles. Ao unless Russell decide to take the patch that refactor all the core-* stuff out in a Kbuild file arm has no use of subdir-ccflags-y and can use the already existing ccflags-y if they decide to cover most of arm with -Werror. Sam