[PATCH 9/14] deb-pkg: improve maintainer identification

Frans Pop
2009-04-22T23:11:23Z

From: maximilian attems <max@stro.at>
Subject: deb-pkg: improve maintainer identification

Try harder to find email and maintainer name.
Debian's own devscripts all use DEBEMAIL or DEBFULLNAME prior to an
eventual EMAIL or NAME environment variable. Match their logic.

"Anonymous" sounds nicer then "Kernel Compiler" if no name is found.

Signed-off-by: maximilian attems <max@stro.at>
Signed-off-by: Frans Pop <elendil@planet.nl>
Cc: Andres Salomon <dilinger@debian.org>
---

I've removed some unnecessary braces. Also, "Anonymous Maintainer" seemed
somewhat redundant to me; just "Anonymous" should do.

diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index 2bd12c1..60f8de2 100644
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -95,14 +95,30 @@ EOF
chmod 755 "$tmpdir/DEBIAN/$script"
done

-name="Kernel Compiler <$(id -nu)@$(hostname -f)>"
+# Try to determine maintainer and email values
+if [ -n "$DEBEMAIL" ]; then
+ email=$DEBEMAIL
+elif [ -n "$EMAIL" ]; then
+ email=$EMAIL
+else
+ email=$(id -nu)@$(hostname -f)
+fi
+if [ -n "$DEBFULLNAME" ]; then
+ name=$DEBFULLNAME
+elif [ -n "$NAME" ]; then
+ name=$NAME
+else
+ name="Anonymous"
+fi
+maintainer="$name <$email>"
+
# Generate a simple changelog template
cat <<EOF > debian/changelog
linux ($packageversion) unstable; urgency=low

* Custom built Linux kernel.

- -- $name $(date -R)
+ -- $maintainer $(date -R)
EOF

# Generate copyright file
@@ -130,7 +146,7 @@ cat <<EOF > debian/control
Source: linux
Section: base
Priority: optional
-Maintainer: $name
+Maintainer: $maintainer
Standards-Version: 3.6.1
EOF