From: Amerigo Wang <amwang@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, Sam Ravnborg <sam@ravnborg.org>,
Amerigo Wang <amwang@redhat.com>,
linux-kbuild@vger.kernel.org
Subject: [RFC Patch] kbuild: implement "make foo.s_c"
Date: Fri, 4 Sep 2009 01:30:06 -0400 [thread overview]
Message-ID: <20090904053233.4396.85814.sendpatchset@localhost.localdomain> (raw)
This patch implements "make path/to/file.s_c", where
"file.s_c" is a file contains both asm and C code, this
is helpful for people to do debugging at asm level.
Currently, we have "make path/to/file.s", but it sucks,
the asm code generated by it is not human-friendly.
Compare "make kernel/spinlock.s" with "make kernel/spinlock.s_c",
as an example.
Cc: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: WANG Cong <amwang@redhat.com>
---
diff --git a/.gitignore b/.gitignore
index b93fb7e..119e00a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -14,6 +14,7 @@
*.o.*
*.a
*.s
+*.s_c
*.ko
*.so
*.so.dbg
diff --git a/Makefile b/Makefile
index 25c615e..9024b42 100644
--- a/Makefile
+++ b/Makefile
@@ -1216,7 +1216,7 @@ clean: archclean $(clean-dirs)
@find . $(RCS_FIND_IGNORE) \
\( -name '*.[oas]' -o -name '*.ko' -o -name '.*.cmd' \
-o -name '.*.d' -o -name '.*.tmp' -o -name '*.mod.c' \
- -o -name '*.symtypes' -o -name 'modules.order' \
+ -o -name '*.s_c' -o -name '*.symtypes' -o -name 'modules.order' \
-o -name 'Module.markers' -o -name '.tmp_*.o.*' \
-o -name '*.gcno' \) -type f -print | xargs rm -f
@@ -1520,6 +1520,8 @@ endif
$(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@)
%.s: %.S prepare scripts FORCE
$(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@)
+%.s_c: %.c prepare scripts FORCE
+ $(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@)
%.o: %.S prepare scripts FORCE
$(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@)
%.symtypes: %.c prepare scripts FORCE
diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 5c4b7a4..e5763ac 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -148,6 +148,11 @@ cmd_cc_s_c = $(CC) $(c_flags) -fverbose-asm -S -o $@ $<
$(obj)/%.s: $(src)/%.c FORCE
$(call if_changed_dep,cc_s_c)
+cmd_cc_s_c_c = $(OBJDUMP) -d -S $< >$@
+
+$(obj)/%.s_c: $(src)/%.o FORCE
+ $(call if_changed,cc_s_c_c)
+
quiet_cmd_cc_i_c = CPP $(quiet_modtag) $@
cmd_cc_i_c = $(CPP) $(c_flags) -o $@ $<
next reply other threads:[~2009-09-04 5:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-04 5:30 Amerigo Wang [this message]
2009-09-04 5:38 ` [RFC Patch] kbuild: implement "make foo.s_c" Andrew Morton
2009-09-04 5:56 ` Amerigo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090904053233.4396.85814.sendpatchset@localhost.localdomain \
--to=amwang@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).