public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Richard Kennedy <richard@rsk.demon.co.uk>
Cc: David Vrabel <david.vrabel@csr.com>,
	Roman Zippel <zippel@linux-m68k.org>,
	linux-usb <linux-usb@vger.kernel.org>,
	linux-kbuild <linux-kbuild@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: UWB Kconfig: cannot set UWB to N in gconfig
Date: Thu, 10 Sep 2009 09:08:06 -0700	[thread overview]
Message-ID: <20090910090806.e8db2300.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1252577154.2340.12.camel@castor>

On Thu, 10 Sep 2009 11:05:54 +0100 Richard Kennedy wrote:

> I sometimes use 'make gconfig' and I noticed that I cannot disable the
> UWB option -- it just won't let me set it to N.

Not specific to 'gconfig'.

> AFAICT this is because the CONFIG USB_WUSB selects UWB which forces it
> on.

Yes.

> applying this patch fixes the issue but I'm not sure if this is the
> right way to go about it.
> 
> any thoughts?

UWB can be disabled by disabling both of these options that are several
entries below it in the same menu:

USB_WHCI_HCD and USB_HWA_HCD

and then returning to UWB and disabling it.

Should users have to figure that out?  no.


> This is against 2.6.31
> 
> 
> diff --git a/drivers/usb/wusbcore/Kconfig b/drivers/usb/wusbcore/Kconfig
> index eb09a0a..cc97041 100644
> --- a/drivers/usb/wusbcore/Kconfig
> +++ b/drivers/usb/wusbcore/Kconfig
> @@ -5,7 +5,7 @@ config USB_WUSB
>  	tristate "Enable Wireless USB extensions (EXPERIMENTAL)"
>  	depends on EXPERIMENTAL
>  	depends on USB
> -        select UWB
> +        depends on UWB
>          select CRYPTO
>          select CRYPTO_BLKCIPHER
>          select CRYPTO_CBC

use tabs, not spaces.


---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/

  reply	other threads:[~2009-09-10 16:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-10 10:05 UWB Kconfig: cannot set UWB to N in gconfig Richard Kennedy
2009-09-10 16:08 ` Randy Dunlap [this message]
2009-09-11 14:00   ` Richard Kennedy
2009-09-14 10:34 ` David Vrabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090910090806.e8db2300.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=david.vrabel@csr.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=richard@rsk.demon.co.uk \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox