From: Frans Pop <elendil@planet.nl>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
linux-kbuild@vger.kernel.org, maximilian attems <max@stro.at>
Subject: Re: [PATCH resend 0/2] fakeroot dwimery for scripts/package/*
Date: Wed, 14 Oct 2009 11:59:02 +0200 [thread overview]
Message-ID: <200910141159.03799.elendil@planet.nl> (raw)
In-Reply-To: <20091014071627.GA6256@merkur.ravnborg.org>
On Wednesday 14 October 2009, Sam Ravnborg wrote:
> Is ROOTCMD an established way to specify this?
>
> I asked google and not too many hits.
> So I think we should come up with something more in the
> line of the other stuff we have.
>
> That could be the longer:
>
> KBUILD_PKG_ROOTCMD
>
> Which with the KBUILD_ prefix could be a globel environment
> variable for some.
Agreed with this change. It is also more in line with how setting a root
command is usually done in Debian. A grep of man pages on my system shows
the following uses:
DEBUILD_ROOTCMD, BDPEP_ROOTCMD, UUPDATE_ROOTCMD, BUILDD_ROOTCMD,
PBUILDERROOTCMD.
I have not tested it, but the patches look good otherwise, so with Sam's
suggested change:
Acked-by: Frans Pop <elendil@planet.nl>
Cheers,
FJP
next prev parent reply other threads:[~2009-10-14 9:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 6:46 [PATCH resend 0/2] fakeroot dwimery for scripts/package/* Jonathan Nieder
2009-10-14 6:54 ` [PATCH resend 1/2] scripts/package: add ROOTCMD variable Jonathan Nieder
2009-10-14 6:55 ` [PATCH resend 2/2] scripts/package: use fakeroot if available Jonathan Nieder
2009-10-14 7:16 ` [PATCH resend 0/2] fakeroot dwimery for scripts/package/* Sam Ravnborg
2009-10-14 9:59 ` Frans Pop [this message]
2009-10-14 11:03 ` maximilian attems
2009-10-15 13:31 ` [PATCH v2 " Jonathan Nieder
2009-10-15 13:35 ` [PATCH v2 1/2] scripts/package: add KBUILD_PKG_ROOTCMD variable Jonathan Nieder
2009-11-24 11:27 ` Michal Marek
2009-11-24 12:03 ` Jonathan Nieder
2009-11-24 13:13 ` Michal Marek
2009-11-24 15:09 ` [PATCH v3 0/3] fakeroot dwimery for deb-pkg target Jonathan Nieder
2009-11-24 15:11 ` [PATCH 1/3] scripts/package: tar-pkg: use tar --owner=root Jonathan Nieder
2009-11-24 15:14 ` [PATCH v3 2/3] scripts/package: add KBUILD_PKG_ROOTCMD variable Jonathan Nieder
2009-11-24 15:21 ` [PATCH v3 3/3] scripts/package: deb-pkg: use fakeroot if available Jonathan Nieder
2009-11-24 19:07 ` Michal Marek
2009-10-15 13:39 ` [PATCH v2 2/2] scripts/package: " Jonathan Nieder
2009-11-04 21:22 ` [PATCH v2 0/2] fakeroot dwimery for scripts/package/* maximilian attems
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910141159.03799.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=jrnieder@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=max@stro.at \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).