From: Rusty Russell <rusty@rustcorp.com.au>
To: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Cc: greg@kroah.com, linux-kbuild@vger.kernel.org,
carmelo73@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/10] module: speed up find_symbol() using binary search on the builtin symbol tables
Date: Wed, 4 Nov 2009 19:01:26 +1030 [thread overview]
Message-ID: <200911041901.26722.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1257242782-10496-10-git-send-email-alan-jenkins@tuffmail.co.uk>
On Tue, 3 Nov 2009 08:36:21 pm Alan Jenkins wrote:
> + for (type = 0; type < EXPORT_TYPE_MAX; type++) {
> + sym = bsearch(name, ksymtab[type].syms, ksymtab[type].num_syms,
> + sizeof(struct kernel_symbol), symbol_compare);
One minor point: Prefer ARRAY_SIZE() here to EXPORT_TYPE_MAX.
It'd be cool if bsearch was typesafe, but that would freak out the Old School
kernel hackers :)
> + for (type = 0; type < EXPORT_TYPE_MAX; type++) {
> + for (i = 0; i < symtab[type].num_syms; i++) {
> + sym = &symtab[type].syms[i];
Same.
Thanks!
Rusty.
next prev parent reply other threads:[~2009-11-04 8:31 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-02 16:52 Fast LKM symbol resolution Alan Jenkins
2009-11-03 3:55 ` Greg KH
2009-11-03 10:06 ` [PATCH 0/10] module: Speed up symbol resolution during module loading (using binary search) Alan Jenkins
2009-11-03 15:58 ` Greg KH
2009-11-05 12:17 ` Rusty Russell
2009-11-03 10:06 ` [PATCH 01/10] ARM: use unified discard definition in linker script Alan Jenkins
2009-11-03 10:06 ` [PATCH 02/10] ARM: unexport symbols used to implement floating point emulation Alan Jenkins
2009-11-03 10:06 ` [PATCH 03/10] module: extract __EXPORT_SYMBOL from module.h into mod_export.h Alan Jenkins
2009-11-03 10:06 ` [PATCH 04/10] module: make MODULE_SYMBOL_PREFIX into a CONFIG option Alan Jenkins
2009-11-03 10:19 ` Mike Frysinger
2009-11-03 12:16 ` Alan Jenkins
2009-11-03 12:30 ` Mike Frysinger
2009-11-03 13:29 ` Paul Mundt
2009-11-03 13:39 ` Mike Frysinger
2009-11-03 13:46 ` Paul Mundt
2009-11-03 13:58 ` Mike Frysinger
2009-11-03 14:07 ` Paul Mundt
2009-11-03 10:06 ` [PATCH 05/10] kbuild: sort the list of symbols exported by the kernel (__ksymtab) Alan Jenkins
2009-11-04 8:19 ` Rusty Russell
2009-11-04 10:00 ` Alan Jenkins
2009-11-04 11:12 ` Mike Frysinger
2009-11-04 17:19 ` Sam Ravnborg
2009-11-05 14:24 ` Alan Jenkins
2009-11-05 16:17 ` Mike Frysinger
2009-11-09 3:17 ` Rusty Russell
2009-11-20 22:20 ` Tony Luck
2009-11-21 0:02 ` Alan Jenkins
2009-11-23 19:53 ` Alex Chiang
2009-11-23 22:44 ` Alan Jenkins
2009-11-24 0:57 ` Rusty Russell
2009-11-24 5:39 ` James Bottomley
2009-11-24 9:28 ` Alan Jenkins
2009-11-24 22:43 ` James Bottomley
2009-11-25 9:15 ` Alan Jenkins
2009-11-25 15:08 ` James Bottomley
2009-11-25 17:01 ` Alan Jenkins
2009-11-27 11:03 ` Rusty Russell
2009-11-26 0:40 ` Andrew Morton
2009-11-26 17:14 ` Alan Jenkins
2009-11-03 10:06 ` [PATCH 06/10] module: refactor symbol tables and try to reduce code size of each_symbol() Alan Jenkins
2009-11-04 8:28 ` Rusty Russell
2009-11-04 9:45 ` Alan Jenkins
2009-11-03 10:06 ` [PATCH 07/10] lib: Add generic binary search function to the kernel Alan Jenkins
2009-11-03 10:06 ` [PATCH 08/10] lib: bsearch - remove redundant special case for arrays of size 0 Alan Jenkins
2009-11-03 10:06 ` [PATCH 09/10] module: speed up find_symbol() using binary search on the builtin symbol tables Alan Jenkins
2009-11-04 8:31 ` Rusty Russell [this message]
2009-11-03 10:06 ` [PATCH 10/10] module: fix is_exported() to return true for all types of exports Alan Jenkins
2009-11-04 8:32 ` Rusty Russell
2009-11-06 5:37 ` Fast LKM symbol resolution Carmelo Amoroso
-- strict thread matches above, loose matches on Subject: below --
2009-11-07 20:59 [PATCH 0/10] module: Speed up symbol resolution during module loading (using binary search) Alan Jenkins
2009-11-07 21:04 ` [PATCH 09/10] module: speed up find_symbol() using binary search on the builtin symbol tables Alan Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911041901.26722.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=carmelo73@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).