From: Sam Ravnborg <sam@ravnborg.org>
To: Tony Finch <dot@dotat.at>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Joe Perches <joe@perches.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
"Justin P. Mattock" <justinmattock@gmail.com>
Subject: Re: [PATCH] unifdef: update to upstream revision 1.189
Date: Fri, 27 Nov 2009 19:17:49 +0100 [thread overview]
Message-ID: <20091127181749.GA16177@merkur.ravnborg.org> (raw)
In-Reply-To: <E1NE3M6-0003Za-OJ@hermes-1.csi.cam.ac.uk>
Hi Tony.
On Fri, Nov 27, 2009 at 03:50:30PM +0000, Tony Finch wrote:
> Fix handling of input files (e.g. with no newline at EOF) that could
> make unifdef get into an unexpected state and call abort().
>
> The new -B option compresses blank lines around a deleted section
> so that blank lines around "paragraphs" of code don't get doubled.
>
> The evaluator can now handle macros with arguments, and unbracketed
> arguments to the "defined" operator.
Can you confirm that this does not regress with respect to the changes
that Russell King implemented in the commit:
eedc9d83eaab2d35fb9dd1ec25b765dec964e26c
("kbuild: fix headers_exports with boolean expression")
I long time ago started a small project to do a dedicated
implementation of unifdef solely for use by the kernel.
Today we do some preprocessing in perl - and then
we pass the result to unifdef file by file.
A dedicated program could do this much faster -
and this would be a bigger incentive for the kernel supplied
tools to actually use the exported headers.
But I never got far with it and I think the code was
lost when I changed computer some time ago.
Sam
next prev parent reply other threads:[~2009-11-27 18:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 13:15 [PATCH] unifdef: update to upstream revision 1.189 Michal Marek
2009-11-27 21:04 ` Sam Ravnborg
[not found] ` <E1NE3M6-0003Za-OJ@hermes-1.csi.cam.ac.uk>
2009-11-27 18:17 ` Sam Ravnborg [this message]
2009-11-27 19:15 ` Tony Finch
2009-11-27 15:50 ` [PATCHv2] unifdef: update to upstream revision 1.190 Tony Finch
2009-12-01 16:12 ` Michal Marek
2009-12-01 16:21 ` Tony Finch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091127181749.GA16177@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=dot@dotat.at \
--cc=joe@perches.com \
--cc=justinmattock@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox