From: Rusty Russell <rusty@rustcorp.com.au>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Michal Marek <mmarek@suse.cz>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] modpost: fix segfault with short symbol names
Date: Tue, 15 Dec 2009 15:44:04 +1030 [thread overview]
Message-ID: <200912151544.04714.rusty@rustcorp.com.au> (raw)
In-Reply-To: <51737.84.105.60.153.1260797592.squirrel@gate.crashing.org>
On Tue, 15 Dec 2009 12:03:12 am Segher Boessenkool wrote:
> > On Sat, Dec 12, 2009 at 04:26:20PM +0100, Segher Boessenkool wrote:
> >> >- if (memcmp(symname, CRC_PFX, strlen(CRC_PFX)) == 0) {
> >> >+ if (strncmp(symname, CRC_PFX, strlen(CRC_PFX)) == 0) {
> >>
> >> This doesn't change anything. In both cases the function will return 0
> >> only if all strlen(CRC_PFX) chars match, and in both cases it can access
> >> strlen(CRC_PFX) chars (strncmp() is allowed to access characters after
> >> the first \0 just fine).
> >
> > str(n)cmp is not allowed to access characters past the NUL byte.
>
> Let me apologise for the confusion.
Mea culpas must be short, to avoid wasting even more time. And they must be
at least as absolute as the incorrect assertion was. This helps us lurkers
and archive readers flush the crap from their brains.
Your mails used _ for emphasis and "You are wrong.". Ouch. I suggest:
"I am *wrong*. Sorry Michal for the brain fart."
Also, please stop channeling Richard B. Johnson.
Rusty.
next prev parent reply other threads:[~2009-12-15 5:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-12 11:02 [PATCH] modpost: fix segfault with short symbol names Michal Marek
2009-12-12 15:26 ` Segher Boessenkool
2009-12-14 10:06 ` Michal Marek
2009-12-14 12:29 ` Segher Boessenkool
2009-12-14 13:33 ` Segher Boessenkool
2009-12-14 16:32 ` Michal Marek
2009-12-15 5:14 ` Rusty Russell [this message]
2009-12-14 23:41 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912151544.04714.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).