From: Al Viro <viro@ZenIV.linux.org.uk>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Andrew Isaacson <adi@vmware.com>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
Rob Landley <rob@landley.net>
Subject: Re: CONFIG_KPROBES=y build requires gawk
Date: Thu, 17 Dec 2009 04:30:21 +0000 [thread overview]
Message-ID: <20091217043021.GV14381@ZenIV.linux.org.uk> (raw)
In-Reply-To: <4B29A8F3.3090306@redhat.com>
On Wed, Dec 16, 2009 at 10:43:47PM -0500, Masami Hiramatsu wrote:
> Al Viro wrote:
> > On Wed, Dec 16, 2009 at 03:56:17PM -0800, Andrew Isaacson wrote:
> >> With CONFIG_KPROBES=y on Ubuntu 9.10 x86_64 default install, I get the
> >> following:
> >>
> >> Error: Your awk doesn't support charactor-class.
> >> Please try to use gawk.
> >
> > Aside of the incorrect suggestion (you need not just gawk, you need that
> > thing installed as awk), the use of GNUisms in there is actually pointless
> > since encoding is bloody fixed.
>
> Hmm, maybe "POSIX awk" will be a better suggestion, isn't it?
Not really.
Note that meaning of [:alpha:] depends on locale, and you are working
with fixed input, in fixed encoding. So you *already* have a dependency
on locale and it's no better or worse way to express the set than A-Za-z
is. With LANG=C both describe the set you are after; in other locales
neither is guaranteed to. And having it set by caller of your script
is trivial.
IOW, you are actually misusing the language feature and while it's easy
to fix, the same fix will remove any benefits compared to universally
available alternative language feature.
next prev parent reply other threads:[~2009-12-17 4:30 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 23:56 CONFIG_KPROBES=y build requires gawk Andrew Isaacson
2009-12-17 1:19 ` Al Viro
2009-12-17 3:43 ` Masami Hiramatsu
2009-12-17 4:30 ` Al Viro [this message]
2009-12-17 5:16 ` Masami Hiramatsu
2009-12-17 1:39 ` Roland Dreier
2009-12-17 2:43 ` H. Peter Anvin
2009-12-17 3:02 ` Al Viro
2009-12-17 4:09 ` Roland Dreier
2009-12-17 5:07 ` H. Peter Anvin
2009-12-17 5:21 ` Masami Hiramatsu
2009-12-17 5:22 ` H. Peter Anvin
2009-12-17 4:09 ` Rob Landley
2009-12-17 3:33 ` Masami Hiramatsu
2009-12-17 3:45 ` H. Peter Anvin
2009-12-17 4:12 ` Rob Landley
2009-12-17 4:15 ` Roland Dreier
2009-12-17 4:56 ` Masami Hiramatsu
2009-12-17 5:11 ` Roland Dreier
2009-12-17 5:21 ` H. Peter Anvin
2009-12-17 5:43 ` Rob Landley
2009-12-17 5:49 ` Masami Hiramatsu
2009-12-17 5:49 ` H. Peter Anvin
2009-12-17 6:06 ` Masami Hiramatsu
2009-12-17 6:08 ` H. Peter Anvin
2009-12-17 6:20 ` Masami Hiramatsu
2009-12-17 6:26 ` H. Peter Anvin
2009-12-17 6:51 ` Roland Dreier
2009-12-17 13:18 ` Masami Hiramatsu
2009-12-17 5:45 ` Sam Ravnborg
2009-12-17 5:56 ` H. Peter Anvin
2009-12-17 6:17 ` Roland Dreier
2009-12-17 6:23 ` H. Peter Anvin
2009-12-17 7:54 ` Sam Ravnborg
2009-12-17 8:09 ` Sam Ravnborg
2009-12-17 11:34 ` Michal Marek
2009-12-17 14:50 ` H. Peter Anvin
2009-12-17 10:42 ` Michal Marek
2009-12-17 13:21 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091217043021.GV14381@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=adi@vmware.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).