linux-kbuild.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aristeu Rozanski <aris@redhat.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-kbuild@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
	linux-kernel@vger.kernel.org, davej@redhat.com, kyle@redhat.com,
	vgoyal@redhat.com, arjan@linux.intel.com
Subject: Re: [PATCH] kconfig: introduce nonint_oldconfig and loose_nonint_oldconfig
Date: Tue, 13 Apr 2010 16:18:00 -0400	[thread overview]
Message-ID: <20100413201759.GY31193@redhat.com> (raw)
In-Reply-To: <20100413130031.d4dec19b.randy.dunlap@oracle.com>

> > This patch has been around for a long time in Fedora and Red Hat Enterprise
> > Linux kernels and it may be useful for others. The nonint_oldconfig target
> > will fail and print the unset config options while loose_nonint_oldconfig will
> > simply let the config option unset. They're useful in distro kernel packages
> > where the config files are built using a combination of smaller config files.
> > The patch's author AFAIK is Arjan van de Ven. Arjan, please add a Signed-off-by
> > if you're the original author.
> 
> Roland McGrath added the loose parts according to his email of 2008.Mar.05:
> "I added this one (loose_nonint_oldconfig target, -B option to conf)."
hm, I can't see the -B there, maybe the functionality he's referring to is
the def_no?

> after Dave Jones posted this patch.
> 
> (adding linux-kbuild mailing list & kbuild maintainer)
> 
> Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
> 
> 
> 
> > Signed-off-by: Aristeu Rozanski <aris@redhat.com> 
> 
> 
> > @@ -613,5 +641,5 @@ int main(int ac, char **av)
> >  			exit(1);
> >  		}
> >  	}
> > -	return 0;
> > +	return return_value;
> >  }
> 
> Having 'make oldconfig' exit with Exit status: 139  (for example)
> can be confusing.  I know that from experience.  It took me a bit
> to find out what that meant.  That part could be improved...
ok, no real reason to keep incrementing that. no different error codes exist
other than "1". Do you think we need to introduce different return codes?

-- 
Aristeu


  reply	other threads:[~2010-04-13 20:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20100413194747.GX31193@redhat.com>
2010-04-13 20:00 ` [PATCH] kconfig: introduce nonint_oldconfig and loose_nonint_oldconfig Randy Dunlap
2010-04-13 20:18   ` Aristeu Rozanski [this message]
2010-04-13 20:24     ` Randy Dunlap
2010-04-13 20:44       ` Aristeu Rozanski
2010-04-13 21:03       ` [PATCH] kconfig: introduce nonint_oldconfig and loose_nonint_oldconfig (v2) Aristeu Rozanski
2010-04-13 21:26         ` Kyle McMartin
2010-04-14 13:22         ` Michal Marek
2010-05-06 16:48           ` [PATCH] kconfig: introduce nonint_oldconfig and loose_nonint_oldconfig (v3) Aristeu Rozanski
2010-05-07  7:02             ` Américo Wang
2010-05-07 14:28               ` Randy Dunlap
2010-05-12  6:12                 ` Américo Wang
2010-06-02 12:44             ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100413201759.GY31193@redhat.com \
    --to=aris@redhat.com \
    --cc=arjan@linux.intel.com \
    --cc=davej@redhat.com \
    --cc=kyle@redhat.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=randy.dunlap@oracle.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).