From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xenotime.net ([72.52.115.56]:38345 "HELO xenotime.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753837Ab0EYPdU convert rfc822-to-8bit (ORCPT ); Tue, 25 May 2010 11:33:20 -0400 Received: from chimera.site ([71.245.98.113]) by xenotime.net for ; Tue, 25 May 2010 08:33:17 -0700 Date: Tue, 25 May 2010 08:33:16 -0700 From: Randy Dunlap Subject: Re: [PATCH 1/3 v2] kbuild/makefiles.txt: Fix examples and content Message-Id: <20100525083316.dba6892a.rdunlap@xenotime.net> In-Reply-To: <20100512043038.GB5358@cr0.nay.redhat.com> References: <1273603385-20587-1-git-send-email-mfm@muteddisk.com> <20100512043038.GB5358@cr0.nay.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: =?ISO-8859-1?Q?Am=E9rico?= Wang Cc: matt mooney , Randy Dunlap , linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org, kernel-janitors@vger.kernel.org, mec@shout.net, kai@tp1.ruhr-uni-bochum.de, sam@ravnborg.org, jengelh@gmx.de On Wed, 12 May 2010 12:30:38 +0800 Américo Wang wrote: > On Tue, May 11, 2010 at 11:43:05AM -0700, matt mooney wrote: > > > >Update section 3.3 Loadable module goals - obj-m, from $(-objs) to $(-y) for easier addition of conditional objects to the module. The examples are also updated to reflect the current state of each Makefile used. > > > >Signed-off-by: matt mooney > > > The whole patchset looks good to me, so, > > Reviewed-by: WANG Cong > > But note that I am not a native English-speaker, let's > see what Randy will say. Added all 3 patches to my patch queue. Thanks, Matt. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***