From: "Toralf Förster" <toralf.foerster@gmx.de>
To: rostedt@goodmis.org
Cc: zippel@linux-m68k.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] streamline_config.pl: use references rather than copied data structures
Date: Thu, 27 May 2010 13:42:08 +0200 [thread overview]
Message-ID: <201005271342.09066.toralf.foerster@gmx.de> (raw)
IMHO there's no need for a copy-by-value
Signed-off-by: Toralf Foerster <toralf.foerster@gmx.de>
---
scripts/kconfig/streamline_config.pl | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/kconfig/streamline_config.pl
b/scripts/kconfig/streamline_config.pl
index afbd54a..574e68f 100644
--- a/scripts/kconfig/streamline_config.pl
+++ b/scripts/kconfig/streamline_config.pl
@@ -406,14 +406,14 @@ close(CIN);
loop:
foreach my $module (keys(%modules)) {
if (defined($objects{$module})) {
- my @arr = @{$objects{$module}};
- foreach my $conf (@arr) {
+ my $arr = $objects{$module};
+ foreach my $conf (@{$arr}) {
if (defined($setconfigs{$conf})) {
next loop;
}
}
print STDERR "module $module did not have configs";
- foreach my $conf (@arr) {
+ foreach my $conf (@{$arr}) {
print STDERR " " , $conf;
}
print STDERR "\n";
--
1.6.4.4
--
MfG/Sincerely
Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3
next reply other threads:[~2010-05-27 11:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 11:42 Toralf Förster [this message]
2010-05-27 13:07 ` [PATCH] streamline_config.pl: use references rather than copied data structures Steven Rostedt
2010-05-27 14:24 ` Toralf Förster
2010-05-27 18:50 ` Steven Rostedt
2010-05-27 19:52 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005271342.09066.toralf.foerster@gmx.de \
--to=toralf.foerster@gmx.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox