[TEMP PATCH] Re: make ARM=arm menuconfig problem in mainline

[TEMP PATCH] Re: make ARM=arm menuconfig problem in mainline

[Randy Dunlap]

On 06/02/10 09:08, Nobin Mathew wrote:
> 
> On Wed, Jun 2, 2010 at 9:27 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>> On Wed, 2 Jun 2010 20:04:28 +0530 Nobin Mathew wrote:
>>
>>> adding linux-arm-kernel@lists.infradead.org
>>>
>>> Hi,
>>>
>>> The following entry creates problem in ARM System type menu. I am
>>> using a Fedora 12 system.
>>
>> What kind of problem does it create?
>> It seems to work for me (on f11, not f12).
>> Does it have something to do with F12 specifically?
>>
>>
>>> Length of bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440,
>>> S3C2442, S3C2443, S3C2450" is the problem. How can I fix it.
>>
>> Describe the problem, please.

[please don't top-post]

> Sorry if attachments are not allowed, when I go to select ARM system
> type(OMAP, Davinci etc), I am not seeing any entries there in the pop
> up window. When I remove  bool "Samsung S3C2410, S3C2412, S3C2413,
> S3C2416, S3C2440,
>>> S3C2442, S3C2443, S3C2450"  it is working fine. I feel it is something to do with length of that string.
> 
> Thanks
> Nobin


OK, I see that now.  Well, it is some kind of problem.
Adding cc to linux-kbuild mailing list.


The patch below fixes the problem temporarily, but the bool string length does
seem to be a problem.

Thanks for your report.

-- 
From: Randy Dunlap <randy.dunlap@oracle.com>

The bool "long string" causes the choices not to be displayed,
so temporarily change it to a shorter string until a real fix
is found.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Reported-by: Nobin Mathew <nobin.mathew@gmail.com>
Cc: Ben Dooks <ben-linux@fluff.org>
---
 arch/arm/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20100602.orig/arch/arm/Kconfig
+++ linux-next-20100602/arch/arm/Kconfig
@@ -629,7 +629,7 @@ config ARCH_SA1100
 	  Support for StrongARM 11x0 based boards.
 
 config ARCH_S3C2410
-	bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440, S3C2442, S3C2443, S3C2450"
+	bool "Samsung S3C24xx"
 	select GENERIC_GPIO
 	select ARCH_HAS_CPUFREQ
 	select HAVE_CLK

Re: [TEMP PATCH] Re: make ARM=arm menuconfig problem in mainline

[Nobin Mathew]

On Wed, Jun 2, 2010 at 10:19 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> On 06/02/10 09:08, Nobin Mathew wrote:
>>
>> On Wed, Jun 2, 2010 at 9:27 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>>> On Wed, 2 Jun 2010 20:04:28 +0530 Nobin Mathew wrote:
>>>
>>>> adding linux-arm-kernel@lists.infradead.org
>>>>
>>>> Hi,
>>>>
>>>> The following entry creates problem in ARM System type menu. I am
>>>> using a Fedora 12 system.
>>>
>>> What kind of problem does it create?
>>> It seems to work for me (on f11, not f12).
>>> Does it have something to do with F12 specifically?
>>>
>>>
>>>> Length of bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440,
>>>> S3C2442, S3C2443, S3C2450" is the problem. How can I fix it.
>>>
>>> Describe the problem, please.
>
> [please don't top-post]
Sorry I forgot. I rarely send mails to this list.
>
>> Sorry if attachments are not allowed, when I go to select ARM system
>> type(OMAP, Davinci etc), I am not seeing any entries there in the pop
>> up window. When I remove  bool "Samsung S3C2410, S3C2412, S3C2413,
>> S3C2416, S3C2440,
>>>> S3C2442, S3C2443, S3C2450"  it is working fine. I feel it is something to do with length of that string.
>>
>> Thanks
>> Nobin
>
>
> OK, I see that now.  Well, it is some kind of problem.
> Adding cc to linux-kbuild mailing list.
>
>
> The patch below fixes the problem temporarily, but the bool string length does
> seem to be a problem.
>
> Thanks for your report.
>
> --
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> The bool "long string" causes the choices not to be displayed,
> so temporarily change it to a shorter string until a real fix
> is found.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Reported-by: Nobin Mathew <nobin.mathew@gmail.com>
> Cc: Ben Dooks <ben-linux@fluff.org>
> ---
>  arch/arm/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20100602.orig/arch/arm/Kconfig
> +++ linux-next-20100602/arch/arm/Kconfig
> @@ -629,7 +629,7 @@ config ARCH_SA1100
>          Support for StrongARM 11x0 based boards.
>
>  config ARCH_S3C2410
> -       bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440, S3C2442, S3C2443, S3C2450"
> +       bool "Samsung S3C24xx"
>        select GENERIC_GPIO
>        select ARCH_HAS_CPUFREQ
>        select HAVE_CLK
>

Re: [TEMP PATCH] Re: make ARM=arm menuconfig problem in mainline

[Ben Dooks]

On Wed, Jun 02, 2010 at 09:49:46AM -0700, Randy Dunlap wrote:
> On 06/02/10 09:08, Nobin Mathew wrote:
> > 
> > On Wed, Jun 2, 2010 at 9:27 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> >> On Wed, 2 Jun 2010 20:04:28 +0530 Nobin Mathew wrote:
> >>
> >>> adding linux-arm-kernel@lists.infradead.org
> >>>
> >>> Hi,
> >>>
> >>> The following entry creates problem in ARM System type menu. I am
> >>> using a Fedora 12 system.
> >>
> >> What kind of problem does it create?
> >> It seems to work for me (on f11, not f12).
> >> Does it have something to do with F12 specifically?
> >>
> >>
> >>> Length of bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440,
> >>> S3C2442, S3C2443, S3C2450" is the problem. How can I fix it.
> >>
> >> Describe the problem, please.
> 
> [please don't top-post]


I can think of several solutions, the first being to remove the S3C prefix
friom all these.

S3C24XX is not acceptable, there's S3C series that are either too old to
be bothered with, or don't fit under this architecture.

how about Samsung S3C: 2410,2412/3,2416,2440/2442,2443,2450

 
> > Sorry if attachments are not allowed, when I go to select ARM system
> > type(OMAP, Davinci etc), I am not seeing any entries there in the pop
> > up window. When I remove  bool "Samsung S3C2410, S3C2412, S3C2413,
> > S3C2416, S3C2440,
> >>> S3C2442, S3C2443, S3C2450"  it is working fine. I feel it is something to do with length of that string.
> > 
> > Thanks
> > Nobin
> 
> 
> OK, I see that now.  Well, it is some kind of problem.
> Adding cc to linux-kbuild mailing list.
> 
> 
> The patch below fixes the problem temporarily, but the bool string length does
> seem to be a problem.
> 
> Thanks for your report.
> 
> -- 
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> The bool "long string" causes the choices not to be displayed,
> so temporarily change it to a shorter string until a real fix
> is found.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Reported-by: Nobin Mathew <nobin.mathew@gmail.com>
> Cc: Ben Dooks <ben-linux@fluff.org>
> ---
>  arch/arm/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20100602.orig/arch/arm/Kconfig
> +++ linux-next-20100602/arch/arm/Kconfig
> @@ -629,7 +629,7 @@ config ARCH_SA1100
>  	  Support for StrongARM 11x0 based boards.
>  
>  config ARCH_S3C2410
> -	bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440, S3C2442, S3C2443, S3C2450"
> +	bool "Samsung S3C24xx"
>  	select GENERIC_GPIO
>  	select ARCH_HAS_CPUFREQ
>  	select HAVE_CLK

-- 
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

Re: [TEMP PATCH v2] Re: make ARM=arm menuconfig problem in mainline

[Randy Dunlap]

On 06/02/10 17:25, Ben Dooks wrote:
> On Wed, Jun 02, 2010 at 09:49:46AM -0700, Randy Dunlap wrote:
>> On 06/02/10 09:08, Nobin Mathew wrote:
>>>
>>> On Wed, Jun 2, 2010 at 9:27 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>>>> On Wed, 2 Jun 2010 20:04:28 +0530 Nobin Mathew wrote:
>>>>
>>>>> adding linux-arm-kernel@lists.infradead.org
>>>>>
>>>>> Hi,
>>>>>
>>>>> The following entry creates problem in ARM System type menu. I am
>>>>> using a Fedora 12 system.
>>>>
>>>> What kind of problem does it create?
>>>> It seems to work for me (on f11, not f12).
>>>> Does it have something to do with F12 specifically?
>>>>
>>>>
>>>>> Length of bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440,
>>>>> S3C2442, S3C2443, S3C2450" is the problem. How can I fix it.
>>>>
>>>> Describe the problem, please.
>>
>> [please don't top-post]
> 
> 
> I can think of several solutions, the first being to remove the S3C prefix
> friom all these.
> 
> S3C24XX is not acceptable, there's S3C series that are either too old to
> be bothered with, or don't fit under this architecture.

and not in the current kernel tree?
I did not find any others in the current tree....

> how about Samsung S3C: 2410,2412/3,2416,2440/2442,2443,2450

OK, that works.

For kbuild/kconfig people:  run:
make ARCH=arm O=test menuconfig

and then select System Type & ARM system type.  The kconfig "choice" menu at this
point looks empty.  It seems to be just a text windowing/display problem.
Pressing the down/up arrow keys will display the choices, although not where they
should be displayed in the rectangle, and they can be selected there.


>>> Sorry if attachments are not allowed, when I go to select ARM system
>>> type(OMAP, Davinci etc), I am not seeing any entries there in the pop
>>> up window. When I remove  bool "Samsung S3C2410, S3C2412, S3C2413,
>>> S3C2416, S3C2440,
>>>>> S3C2442, S3C2443, S3C2450"  it is working fine. I feel it is something to do with length of that string.
>>>
>>> Thanks
>>> Nobin
>>
>>
>> OK, I see that now.  Well, it is some kind of problem.
>> Adding cc to linux-kbuild mailing list.
>>
>>
>> The patch below fixes the problem temporarily, but the bool string length does
>> seem to be a problem.
>>
>> Thanks for your report.


---
From: Randy Dunlap <randy.dunlap@oracle.com>

"bool <long string>" causes kconfig choices not to be displayed
correctly, so temporarily change it to a shorter string until a real
fix is found.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Reported-by: Nobin Mathew <nobin.mathew@gmail.com>
Cc: Ben Dooks <ben-linux@fluff.org>
---
 arch/arm/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20100602.orig/arch/arm/Kconfig
+++ linux-next-20100602/arch/arm/Kconfig
@@ -629,7 +629,7 @@ config ARCH_SA1100
 	  Support for StrongARM 11x0 based boards.
 
 config ARCH_S3C2410
-	bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440, S3C2442, S3C2443, S3C2450"
+	bool "Samsung S3C: 2410,2412/3,2416,2440/2442,2443,2450"
 	select GENERIC_GPIO
 	select ARCH_HAS_CPUFREQ
 	select HAVE_CLK

Re: [TEMP PATCH v2] Re: make ARM=arm menuconfig problem in mainline

[Li Zefan]

Randy Dunlap wrote:
> On 06/02/10 17:25, Ben Dooks wrote:
>> On Wed, Jun 02, 2010 at 09:49:46AM -0700, Randy Dunlap wrote:
>>> On 06/02/10 09:08, Nobin Mathew wrote:
>>>> On Wed, Jun 2, 2010 at 9:27 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>>>>> On Wed, 2 Jun 2010 20:04:28 +0530 Nobin Mathew wrote:
>>>>>
>>>>>> adding linux-arm-kernel@lists.infradead.org
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> The following entry creates problem in ARM System type menu. I am
>>>>>> using a Fedora 12 system.
>>>>> What kind of problem does it create?
>>>>> It seems to work for me (on f11, not f12).
>>>>> Does it have something to do with F12 specifically?
>>>>>
>>>>>
>>>>>> Length of bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440,
>>>>>> S3C2442, S3C2443, S3C2450" is the problem. How can I fix it.
>>>>> Describe the problem, please.
>>> [please don't top-post]
>>
>> I can think of several solutions, the first being to remove the S3C prefix
>> friom all these.
>>
>> S3C24XX is not acceptable, there's S3C series that are either too old to
>> be bothered with, or don't fit under this architecture.
> 
> and not in the current kernel tree?
> I did not find any others in the current tree....
> 
>> how about Samsung S3C: 2410,2412/3,2416,2440/2442,2443,2450
> 
> OK, that works.
> 
> For kbuild/kconfig people:  run:
> make ARCH=arm O=test menuconfig
> 
> and then select System Type & ARM system type.  The kconfig "choice" menu at this
> point looks empty.  It seems to be just a text windowing/display problem.
> Pressing the down/up arrow keys will display the choices, although not where they
> should be displayed in the rectangle, and they can be selected there.
> 

I've found out the cause of this bug, and I'll cook up a patch soon. ;)