From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "Peter Hüwe" <PeterHuewe@gmx.de>
Cc: "Sascha Hauer" <kernel@pengutronix.de>,
"Russell King" <linux@arm.linux.org.uk>,
"Baruch Siach" <baruch@tkos.co.il>,
"Eric Bénard" <eric@eukrea.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Russell King" <rmk+kernel@arm.linux.org.uk>,
linux-kbuild@vger.kernel.org
Subject: Re: Subject: [PATCH] arm: fix KConfig warning for mach-mx25
Date: Tue, 29 Jun 2010 08:58:17 +0200 [thread overview]
Message-ID: <20100629065817.GA23160@pengutronix.de> (raw)
In-Reply-To: <201006290005.20875.PeterHuewe@gmx.de>
Hiho,
[added linux-kbuild@vger.kernel.org to Cc:]
On Tue, Jun 29, 2010 at 12:05:20AM +0200, Peter Hüwe wrote:
> From: Peter Huewe <peterhuewe@gmx.de
>
> This patch fixes a KConfig warning:
> "arch/arm/mach-mx25/Kconfig:18:warning: choice value used outside its
> choice group"
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
The problem also goes away when renaming one of the two
MACH_EUKREA_MBIMXSD_BASEBOARD (the other MACH_EUKREA_MBIMXSD_BASEBOARD
is in arch/arm/mach-mx3/Kconfig). AFAIK Eric already sent a patch to
fix this. I think this is the real issue, I don't know why the warning
goes away with your patch.
Nevertheless I like your patch. And note there are two other variables
in arch/arm/mach-mx2 that could benefit from the same "fix". (But as I
moved this file in my tree I suggest to wait until my changes hit Linus'
tree and then fix arch/arm/mach-imx/Kconfig.)
Best regards
Uwe
> ---
> KernelVersion: linux-next-20100628
> arch/arm/mach-mx25/Kconfig | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-mx25/Kconfig b/arch/arm/mach-mx25/Kconfig
> index 3a6668e..2f436ed 100644
> --- a/arch/arm/mach-mx25/Kconfig
> +++ b/arch/arm/mach-mx25/Kconfig
> @@ -15,8 +15,7 @@ choice
> default MACH_EUKREA_MBIMXSD_BASEBOARD
>
> config MACH_EUKREA_MBIMXSD_BASEBOARD
> - prompt "Eukrea MBIMXSD development board"
> - bool
> + bool "Eukrea MBIMXSD development board"
> help
> This adds board specific devices that can be found on Eukrea's
> MBIMXSD evaluation board.
> --
> 1.7.1
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
parent reply other threads:[~2010-06-29 6:58 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <201006290005.20875.PeterHuewe@gmx.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100629065817.GA23160@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=PeterHuewe@gmx.de \
--cc=baruch@tkos.co.il \
--cc=eric@eukrea.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox