public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Andrej Gelenberg <andrej.gelenberg@udo.edu>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	Nir Tzachar <nir.tzachar@gmail.com>
Subject: Re: [PATCH] nconfig: Fix segfault when menu is empty
Date: Fri, 13 Aug 2010 00:28:43 +0200	[thread overview]
Message-ID: <20100812222843.GA19505@sepie.suse.cz> (raw)
In-Reply-To: <4C569703.9010607@udo.edu>

On Mon, Aug 02, 2010 at 11:59:31AM +0200, Andrej Gelenberg wrote:
> there is a small bug in nconf, which cause segfault in empty menus
> (press right arrow in empty menu). Patch is attached.
> 
> Regards,
> Andrej Gelenberg

> From 60265c2f3db2616d3dc493785a47a301f73419bd Mon Sep 17 00:00:00 2001
> From: Andrej Gelenberg <andrej.gelenberg@udo.edu>
> Date: Mon, 2 Aug 2010 11:41:36 +0200
> Subject: [PATCH] nconfig: Fix segfault when menu is empty
> 
> nconf crush with segfault if press right arrow in empty menu.
> 
> Signed-off-by: Andrej Gelenberg <andrej.gelenberg@udo.edu>
> ---
>  scripts/kconfig/nconf.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
> index 762caf8..3db3ca6 100644
> --- a/scripts/kconfig/nconf.c
> +++ b/scripts/kconfig/nconf.c
> @@ -676,6 +676,7 @@ static void *item_data(void)
>  	struct mitem *mcur;
>  
>  	cur = current_item(curses_menu);
> +	if ( ! cur ) return NULL;
>  	mcur = (struct mitem *) item_userptr(cur);
>  	return mcur->usrptr;

Applied after fixing indentation (see Documentation/CodingStyle).

Michal

      reply	other threads:[~2010-08-12 22:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-02  9:59 [PATCH] nconfig: Fix segfault when menu is empty Andrej Gelenberg
2010-08-12 22:28 ` Michal Marek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100812222843.GA19505@sepie.suse.cz \
    --to=mmarek@suse.cz \
    --cc=andrej.gelenberg@udo.edu \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nir.tzachar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox