From: Sam Ravnborg <sam@ravnborg.org>
To: Jan Beulich <JBeulich@novell.com>, Michal Marek <mmarek@suse.cz>,
linux-kbuild <linux-kbuild@vger.kernel.org>
Cc: linux-kernel@vger.kernel.org, Andrew Benton <b3nton@gmail.com>
Subject: Re: [PATCH] fixes for using make 3.82
Date: Mon, 16 Aug 2010 13:41:31 +0200 [thread overview]
Message-ID: <20100816114131.GA7122@merkur.ravnborg.org> (raw)
In-Reply-To: <4C6936120200007800010064@vpn.id2.novell.com>
Added: Michael Marek (kbuild maintainer) + linux-kbuild.
I assume this fixes firmware build reported by Andrew Benton (cc:ed).
Sam
On Mon, Aug 16, 2010 at 11:58:58AM +0100, Jan Beulich wrote:
> It doesn't like pattern and explicit rules to be on the same line,
> and it seems to be more picky when matching file (or really directory)
> names with different numbers of trailing slashes.
>
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> ---
> firmware/Makefile | 2 +-
> scripts/mkmakefile | 4 +++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> --- linux-2.6.36-rc1/firmware/Makefile
> +++ 2.6.36-rc1-make-3.82-fixes/firmware/Makefile
> @@ -142,7 +142,7 @@ fw-shipped-$(CONFIG_YAM) += yam/1200.bin
> fw-shipped-all := $(fw-shipped-y) $(fw-shipped-m) $(fw-shipped-)
>
> # Directories which we _might_ need to create, so we have a rule for them.
> -firmware-dirs := $(sort $(patsubst %,$(objtree)/$(obj)/%/,$(dir $(fw-external-y) $(fw-shipped-all))))
> +firmware-dirs := $(sort $(addprefix $(objtree)/$(obj)/,$(dir $(fw-external-y) $(fw-shipped-all))))
>
> quiet_cmd_mkdir = MKDIR $(patsubst $(objtree)/%,%,$@)
> cmd_mkdir = mkdir -p $@
> --- linux-2.6.36-rc1/scripts/mkmakefile
> +++ 2.6.36-rc1-make-3.82-fixes/scripts/mkmakefile
> @@ -44,7 +44,9 @@ all:
>
> Makefile:;
>
> -\$(all) %/: all
> +\$(all): all
> @:
>
> +%/: all
> + @:
> EOF
>
>
next parent reply other threads:[~2010-08-16 11:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4C6936120200007800010064@vpn.id2.novell.com>
2010-08-16 11:41 ` Sam Ravnborg [this message]
2010-08-16 11:53 ` [PATCH] fixes for using make 3.82 Jan Beulich
2010-08-16 13:17 ` Andrew Benton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100816114131.GA7122@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=JBeulich@novell.com \
--cc=b3nton@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox