* Re: [PATCH] modules: don't call depmod when overriding external module install path [not found] <1281945814-9720-1-git-send-email-jcm@jonmasters.org> @ 2010-08-16 10:43 ` Rusty Russell 2010-08-16 22:26 ` Jon Masters 2010-08-17 2:51 ` Américo Wang 0 siblings, 2 replies; 3+ messages in thread From: Rusty Russell @ 2010-08-16 10:43 UTC (permalink / raw) To: Jon Masters Cc: Linux Kernel Mailing List, Andrew Morton, Michal Marek, linux-kbuild On Mon, 16 Aug 2010 05:33:34 pm Jon Masters wrote: > Recent kernels include an additional call to depmod during the installation > of external kernel modules as a convenience, in order to ensure that those > modules are picked up by the module loading tools/initramfs scripts, etc. > Although this call is potentially of some value, it should not be made > when explicitly setting INSTALL_MOD_PATH to a different location. This > avoids creating extraneous modules.* files that will never be used. > > Signed-off-by: Jon Masters <jcm@jonmasters.org> Acked-by: Rusty Russell <rusty@rustcorp.com.au> I leave the Makefile stuff to the kbuild people... > --- > Makefile | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/Makefile b/Makefile > index f3bdff8..2b904f2 100644 > --- a/Makefile > +++ b/Makefile > @@ -1325,7 +1325,9 @@ _emodinst_: > > PHONY += _emodinst_post > _emodinst_post: _emodinst_ > +ifeq ($(INSTALL_MOD_PATH),) > $(call cmd,depmod) > +endif > > clean-dirs := $(addprefix _clean_,$(KBUILD_EXTMOD)) Thanks, Rusty. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] modules: don't call depmod when overriding external module install path 2010-08-16 10:43 ` [PATCH] modules: don't call depmod when overriding external module install path Rusty Russell @ 2010-08-16 22:26 ` Jon Masters 2010-08-17 2:51 ` Américo Wang 1 sibling, 0 replies; 3+ messages in thread From: Jon Masters @ 2010-08-16 22:26 UTC (permalink / raw) To: Rusty Russell Cc: Jon Masters, Linux Kernel Mailing List, Andrew Morton, Michal Marek, linux-kbuild On Mon, 2010-08-16 at 20:13 +0930, Rusty Russell wrote: > On Mon, 16 Aug 2010 05:33:34 pm Jon Masters wrote: > > Recent kernels include an additional call to depmod during the installation > > of external kernel modules as a convenience, in order to ensure that those > > modules are picked up by the module loading tools/initramfs scripts, etc. > > Although this call is potentially of some value, it should not be made > > when explicitly setting INSTALL_MOD_PATH to a different location. This > > avoids creating extraneous modules.* files that will never be used. > > > > Signed-off-by: Jon Masters <jcm@jonmasters.org> > > Acked-by: Rusty Russell <rusty@rustcorp.com.au> > > I leave the Makefile stuff to the kbuild people... Hey, thanks for forwarding. I figured I would do that, but I see you already did. And yea, next time I'll ping the Kbuild folks directly. Jon. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] modules: don't call depmod when overriding external module install path 2010-08-16 10:43 ` [PATCH] modules: don't call depmod when overriding external module install path Rusty Russell 2010-08-16 22:26 ` Jon Masters @ 2010-08-17 2:51 ` Américo Wang 1 sibling, 0 replies; 3+ messages in thread From: Américo Wang @ 2010-08-17 2:51 UTC (permalink / raw) To: Rusty Russell Cc: Jon Masters, Linux Kernel Mailing List, Andrew Morton, Michal Marek, linux-kbuild On Mon, Aug 16, 2010 at 08:13:45PM +0930, Rusty Russell wrote: >On Mon, 16 Aug 2010 05:33:34 pm Jon Masters wrote: >> Recent kernels include an additional call to depmod during the installation >> of external kernel modules as a convenience, in order to ensure that those >> modules are picked up by the module loading tools/initramfs scripts, etc. >> Although this call is potentially of some value, it should not be made >> when explicitly setting INSTALL_MOD_PATH to a different location. This >> avoids creating extraneous modules.* files that will never be used. >> >> Signed-off-by: Jon Masters <jcm@jonmasters.org> > >Acked-by: Rusty Russell <rusty@rustcorp.com.au> > >I leave the Makefile stuff to the kbuild people... > Looks good for me, Acked-by: WANG Cong <xiyou.wangcong@gmail.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-17 2:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1281945814-9720-1-git-send-email-jcm@jonmasters.org>
2010-08-16 10:43 ` [PATCH] modules: don't call depmod when overriding external module install path Rusty Russell
2010-08-16 22:26 ` Jon Masters
2010-08-17 2:51 ` Américo Wang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox