Re: [PATCH 08/20] m68knommu: change to new flag variables

public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed

* Re: [PATCH 08/20] m68knommu: change to new flag variables
       [not found] ` <4CA18E00.7090207@snapgear.com>
@ 2010-09-28  7:16   ` matt mooney
  2010-09-28 13:22     ` Greg Ungerer
  2010-09-29 14:36     ` Michal Marek
  0 siblings, 2 replies; 5+ messages in thread
From: matt mooney @ 2010-09-28  7:16 UTC (permalink / raw)
  To: Greg Ungerer
  Cc: Greg Ungerer, Andrew Morton, David Howells, Tim Abbott,
	linux-kernel, kernel-janitors, linux-kbuild

On 16:41 Tue 28 Sep     , Greg Ungerer wrote:
> 
> Hi Matt,
> 
> On 23/09/10 16:50, matt mooney wrote:
> >Replace EXTRA_CFLAGS with ccflags-y and EXTRA_AFLAGS with asflags-y.
> >
> >Signed-off-by: matt mooney<mfm@muteddisk.com>
> 
> Looks fine to me. Are you looking for this to go through
> maintainer trees, or the whole patch series in one go?

Hi Greg,

My original intent was through the maintainer trees; however, I am starting to
realize that it probably would have been best to all go into the kbuild tree as
one patch series. That being said, some people have picked them up and others
have just acked, so really whatever is easiest for you. All unapplied will
eventually go through the kbuild tree.

Thanks,
mfm

> Acked-by: Greg Ungerer <gerg@uclinux.org>
> 
> Regards
> Greg
> 
> 
> >---
> >  arch/m68knommu/platform/5206/Makefile     |    4 ++--
> >  arch/m68knommu/platform/5206e/Makefile    |    4 ++--
> >  arch/m68knommu/platform/520x/Makefile     |    4 ++--
> >  arch/m68knommu/platform/523x/Makefile     |    4 ++--
> >  arch/m68knommu/platform/5249/Makefile     |    4 ++--
> >  arch/m68knommu/platform/5272/Makefile     |    4 ++--
> >  arch/m68knommu/platform/527x/Makefile     |    4 ++--
> >  arch/m68knommu/platform/528x/Makefile     |    4 ++--
> >  arch/m68knommu/platform/5307/Makefile     |    4 ++--
> >  arch/m68knommu/platform/532x/Makefile     |    4 ++--
> >  arch/m68knommu/platform/5407/Makefile     |    4 ++--
> >  arch/m68knommu/platform/coldfire/Makefile |    4 ++--
> >  12 files changed, 24 insertions(+), 24 deletions(-)
> >
> >diff --git a/arch/m68knommu/platform/5206/Makefile b/arch/m68knommu/platform/5206/Makefile
> >index 113c333..b5db056 100644
> >--- a/arch/m68knommu/platform/5206/Makefile
> >+++ b/arch/m68knommu/platform/5206/Makefile
> >@@ -8,8 +8,8 @@
> >  # on the console port whenever a DBG interrupt occurs.  You have to
> >  # set up you HW breakpoints to trigger a DBG interrupt:
> >  #
> >-# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> >-# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> >+# ccflags-y := -DTRAP_DBG_INTERRUPT
> >+# asflags-y := -DTRAP_DBG_INTERRUPT
> >  #
> >
> >  asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> >diff --git a/arch/m68knommu/platform/5206e/Makefile b/arch/m68knommu/platform/5206e/Makefile
> >index 113c333..b5db056 100644
> >--- a/arch/m68knommu/platform/5206e/Makefile
> >+++ b/arch/m68knommu/platform/5206e/Makefile
> >@@ -8,8 +8,8 @@
> >  # on the console port whenever a DBG interrupt occurs.  You have to
> >  # set up you HW breakpoints to trigger a DBG interrupt:
> >  #
> >-# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> >-# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> >+# ccflags-y := -DTRAP_DBG_INTERRUPT
> >+# asflags-y := -DTRAP_DBG_INTERRUPT
> >  #
> >
> >  asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> >diff --git a/arch/m68knommu/platform/520x/Makefile b/arch/m68knommu/platform/520x/Makefile
> >index 435ab34..ad3f4e5 100644
> >--- a/arch/m68knommu/platform/520x/Makefile
> >+++ b/arch/m68knommu/platform/520x/Makefile
> >@@ -8,8 +8,8 @@
> >  # on the console port whenever a DBG interrupt occurs.  You have to
> >  # set up you HW breakpoints to trigger a DBG interrupt:
> >  #
> >-# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> >-# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> >+# ccflags-y := -DTRAP_DBG_INTERRUPT
> >+# asflags-y := -DTRAP_DBG_INTERRUPT
> >  #
> >
> >  asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> >diff --git a/arch/m68knommu/platform/523x/Makefile b/arch/m68knommu/platform/523x/Makefile
> >index b8f9b45..c04b8f7 100644
> >--- a/arch/m68knommu/platform/523x/Makefile
> >+++ b/arch/m68knommu/platform/523x/Makefile
> >@@ -8,8 +8,8 @@
> >  # on the console port whenever a DBG interrupt occurs.  You have to
> >  # set up you HW breakpoints to trigger a DBG interrupt:
> >  #
> >-# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> >-# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> >+# ccflags-y := -DTRAP_DBG_INTERRUPT
> >+# asflags-y := -DTRAP_DBG_INTERRUPT
> >  #
> >
> >  asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> >diff --git a/arch/m68knommu/platform/5249/Makefile b/arch/m68knommu/platform/5249/Makefile
> >index f56225d..4bed30f 100644
> >--- a/arch/m68knommu/platform/5249/Makefile
> >+++ b/arch/m68knommu/platform/5249/Makefile
> >@@ -8,8 +8,8 @@
> >  # on the console port whenever a DBG interrupt occurs.  You have to
> >  # set up you HW breakpoints to trigger a DBG interrupt:
> >  #
> >-# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> >-# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> >+# ccflags-y := -DTRAP_DBG_INTERRUPT
> >+# asflags-y := -DTRAP_DBG_INTERRUPT
> >  #
> >
> >  asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> >diff --git a/arch/m68knommu/platform/5272/Makefile b/arch/m68knommu/platform/5272/Makefile
> >index 93673ef..34110fc 100644
> >--- a/arch/m68knommu/platform/5272/Makefile
> >+++ b/arch/m68knommu/platform/5272/Makefile
> >@@ -8,8 +8,8 @@
> >  # on the console port whenever a DBG interrupt occurs.  You have to
> >  # set up you HW breakpoints to trigger a DBG interrupt:
> >  #
> >-# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> >-# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> >+# ccflags-y := -DTRAP_DBG_INTERRUPT
> >+# asflags-y := -DTRAP_DBG_INTERRUPT
> >  #
> >
> >  asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> >diff --git a/arch/m68knommu/platform/527x/Makefile b/arch/m68knommu/platform/527x/Makefile
> >index 3d90e6d..6ac4b57 100644
> >--- a/arch/m68knommu/platform/527x/Makefile
> >+++ b/arch/m68knommu/platform/527x/Makefile
> >@@ -8,8 +8,8 @@
> >  # on the console port whenever a DBG interrupt occurs.  You have to
> >  # set up you HW breakpoints to trigger a DBG interrupt:
> >  #
> >-# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> >-# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> >+# ccflags-y := -DTRAP_DBG_INTERRUPT
> >+# asflags-y := -DTRAP_DBG_INTERRUPT
> >  #
> >
> >  asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> >diff --git a/arch/m68knommu/platform/528x/Makefile b/arch/m68knommu/platform/528x/Makefile
> >index 3d90e6d..6ac4b57 100644
> >--- a/arch/m68knommu/platform/528x/Makefile
> >+++ b/arch/m68knommu/platform/528x/Makefile
> >@@ -8,8 +8,8 @@
> >  # on the console port whenever a DBG interrupt occurs.  You have to
> >  # set up you HW breakpoints to trigger a DBG interrupt:
> >  #
> >-# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> >-# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> >+# ccflags-y := -DTRAP_DBG_INTERRUPT
> >+# asflags-y := -DTRAP_DBG_INTERRUPT
> >  #
> >
> >  asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> >diff --git a/arch/m68knommu/platform/5307/Makefile b/arch/m68knommu/platform/5307/Makefile
> >index 6de5269..d4293b7 100644
> >--- a/arch/m68knommu/platform/5307/Makefile
> >+++ b/arch/m68knommu/platform/5307/Makefile
> >@@ -8,8 +8,8 @@
> >  # on the console port whenever a DBG interrupt occurs. You have to
> >  # set up you HW breakpoints to trigger a DBG interrupt:
> >  #
> >-# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> >-# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> >+# ccflags-y := -DTRAP_DBG_INTERRUPT
> >+# asflags-y := -DTRAP_DBG_INTERRUPT
> >  #
> >
> >  asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> >diff --git a/arch/m68knommu/platform/532x/Makefile b/arch/m68knommu/platform/532x/Makefile
> >index 4cc2324..ce01669 100644
> >--- a/arch/m68knommu/platform/532x/Makefile
> >+++ b/arch/m68knommu/platform/532x/Makefile
> >@@ -8,8 +8,8 @@
> >  # on the console port whenever a DBG interrupt occurs. You have to
> >  # set up you HW breakpoints to trigger a DBG interrupt:
> >  #
> >-# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> >-# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> >+# ccflags-y := -DTRAP_DBG_INTERRUPT
> >+# asflags-y := -DTRAP_DBG_INTERRUPT
> >  #
> >
> >  asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> >diff --git a/arch/m68knommu/platform/5407/Makefile b/arch/m68knommu/platform/5407/Makefile
> >index dee62c5..e83fe14 100644
> >--- a/arch/m68knommu/platform/5407/Makefile
> >+++ b/arch/m68knommu/platform/5407/Makefile
> >@@ -8,8 +8,8 @@
> >  # on the console port whenever a DBG interrupt occurs. You have to
> >  # set up you HW breakpoints to trigger a DBG interrupt:
> >  #
> >-# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> >-# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> >+# ccflags-y := -DTRAP_DBG_INTERRUPT
> >+# asflags-y := -DTRAP_DBG_INTERRUPT
> >  #
> >
> >  asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> >diff --git a/arch/m68knommu/platform/coldfire/Makefile b/arch/m68knommu/platform/coldfire/Makefile
> >index f72a0e5..788c13f 100644
> >--- a/arch/m68knommu/platform/coldfire/Makefile
> >+++ b/arch/m68knommu/platform/coldfire/Makefile
> >@@ -8,8 +8,8 @@
> >  # on the console port whenever a DBG interrupt occurs. You have to
> >  # set up you HW breakpoints to trigger a DBG interrupt:
> >  #
> >-# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> >-# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> >+# ccflags-y := -DTRAP_DBG_INTERRUPT
> >+# asflags-y := -DTRAP_DBG_INTERRUPT
> >  #
> >
> >  asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 08/20] m68knommu: change to new flag variables
  2010-09-28  7:16   ` [PATCH 08/20] m68knommu: change to new flag variables matt mooney
@ 2010-09-28 13:22     ` Greg Ungerer
  2010-09-29 14:36     ` Michal Marek
  1 sibling, 0 replies; 5+ messages in thread
From: Greg Ungerer @ 2010-09-28 13:22 UTC (permalink / raw)
  To: Greg Ungerer, Andrew Morton, David Howells, Tim Abbott,
	linux-kernel, kernel-janitors, linux-kbuild


Hi Matt,

On 28/09/10 17:16, matt mooney wrote:
> On 16:41 Tue 28 Sep     , Greg Ungerer wrote:
>>
>> Hi Matt,
>>
>> On 23/09/10 16:50, matt mooney wrote:
>>> Replace EXTRA_CFLAGS with ccflags-y and EXTRA_AFLAGS with asflags-y.
>>>
>>> Signed-off-by: matt mooney<mfm@muteddisk.com>
>>
>> Looks fine to me. Are you looking for this to go through
>> maintainer trees, or the whole patch series in one go?
>
> Hi Greg,
>
> My original intent was through the maintainer trees; however, I am starting to
> realize that it probably would have been best to all go into the kbuild tree as
> one patch series. That being said, some people have picked them up and others
> have just acked, so really whatever is easiest for you. All unapplied will
> eventually go through the kbuild tree.

I am happy to pick up the m68knommu change and send up-stream.

Regards
Greg


>> Acked-by: Greg Ungerer<gerg@uclinux.org>
>>
>> Regards
>> Greg
>>
>>
>>> ---
>>>   arch/m68knommu/platform/5206/Makefile     |    4 ++--
>>>   arch/m68knommu/platform/5206e/Makefile    |    4 ++--
>>>   arch/m68knommu/platform/520x/Makefile     |    4 ++--
>>>   arch/m68knommu/platform/523x/Makefile     |    4 ++--
>>>   arch/m68knommu/platform/5249/Makefile     |    4 ++--
>>>   arch/m68knommu/platform/5272/Makefile     |    4 ++--
>>>   arch/m68knommu/platform/527x/Makefile     |    4 ++--
>>>   arch/m68knommu/platform/528x/Makefile     |    4 ++--
>>>   arch/m68knommu/platform/5307/Makefile     |    4 ++--
>>>   arch/m68knommu/platform/532x/Makefile     |    4 ++--
>>>   arch/m68knommu/platform/5407/Makefile     |    4 ++--
>>>   arch/m68knommu/platform/coldfire/Makefile |    4 ++--
>>>   12 files changed, 24 insertions(+), 24 deletions(-)
>>>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 08/20] m68knommu: change to new flag variables
  2010-09-28  7:16   ` [PATCH 08/20] m68knommu: change to new flag variables matt mooney
  2010-09-28 13:22     ` Greg Ungerer
@ 2010-09-29 14:36     ` Michal Marek
  2010-09-29 23:15       ` matt mooney
  1 sibling, 1 reply; 5+ messages in thread
From: Michal Marek @ 2010-09-29 14:36 UTC (permalink / raw)
  To: matt mooney
  Cc: Greg Ungerer, Greg Ungerer, Andrew Morton, David Howells,
	Tim Abbott, linux-kernel, kernel-janitors, linux-kbuild

On 28.9.2010 09:16, matt mooney wrote:
> My original intent was through the maintainer trees; however, I am starting to
> realize that it probably would have been best to all go into the kbuild tree as
> one patch series. That being said, some people have picked them up and others
> have just acked, so really whatever is easiest for you. All unapplied will
> eventually go through the kbuild tree.

Please try push as much through maintainer trees as possible, to avoid
unnecessary merge conflicts. Of course, if you end up with some patches
that nobody is picking up, I'll apply them to the kbuild tree.

Thanks,
Michal

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 08/20] m68knommu: change to new flag variables
  2010-09-29 14:36     ` Michal Marek
@ 2010-09-29 23:15       ` matt mooney
  2010-09-30 20:51         ` Michal Marek
  0 siblings, 1 reply; 5+ messages in thread
From: matt mooney @ 2010-09-29 23:15 UTC (permalink / raw)
  To: Michal Marek
  Cc: Greg Ungerer, Greg Ungerer, Andrew Morton, David Howells,
	Tim Abbott, linux-kernel, kernel-janitors, linux-kbuild

On 16:36 Wed 29 Sep     , Michal Marek wrote:
> On 28.9.2010 09:16, matt mooney wrote:
> > My original intent was through the maintainer trees; however, I am starting to
> > realize that it probably would have been best to all go into the kbuild tree as
> > one patch series. That being said, some people have picked them up and others
> > have just acked, so really whatever is easiest for you. All unapplied will
> > eventually go through the kbuild tree.
> 
> Please try push as much through maintainer trees as possible, to avoid
> unnecessary merge conflicts. Of course, if you end up with some patches
> that nobody is picking up, I'll apply them to the kbuild tree.

Okay, if anybody else asks, I will definitely ask them kindly to pick them
up. There are, however, some patches that will need to go through the kbuild
tree because some maintainers have already acked the patches and not picked them
up. I will wait a couple more weeks, and then I will resend to you and the
kbuild list with all acks added.

-mfm

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 08/20] m68knommu: change to new flag variables
  2010-09-29 23:15       ` matt mooney
@ 2010-09-30 20:51         ` Michal Marek
  0 siblings, 0 replies; 5+ messages in thread
From: Michal Marek @ 2010-09-30 20:51 UTC (permalink / raw)
  To: Greg Ungerer, Greg Ungerer, Andrew Morton, David Howells,
	Tim Abbott, linux-kernel, kernel-janitors, linux-kbuild

On 30.9.2010 01:15, matt mooney wrote:
> Okay, if anybody else asks, I will definitely ask them kindly to pick them
> up. There are, however, some patches that will need to go through the kbuild
> tree because some maintainers have already acked the patches and not picked them
> up.

You can ask them to apply the patches :).


 I will wait a couple more weeks, and then I will resend to you and the
> kbuild list with all acks added.

OK.

Michal

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2010-09-30 20:51 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1285224645-29728-1-git-send-email-mfm@muteddisk.com>
     [not found] ` <4CA18E00.7090207@snapgear.com>
2010-09-28  7:16   ` [PATCH 08/20] m68knommu: change to new flag variables matt mooney
2010-09-28 13:22     ` Greg Ungerer
2010-09-29 14:36     ` Michal Marek
2010-09-29 23:15       ` matt mooney
2010-09-30 20:51         ` Michal Marek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox