From: Michal Marek <mmarek@suse.cz>
To: Arnaud Lacombe <lacombar@gmail.com>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 1/2] kconfig/conf: kill deadcode
Date: Wed, 15 Dec 2010 14:58:50 +0100 [thread overview]
Message-ID: <20101215135850.GC18269@pobox.suse.cz> (raw)
In-Reply-To: <1291531935-6183-1-git-send-email-lacombar@gmail.com>
On Sun, Dec 05, 2010 at 01:52:14AM -0500, Arnaud Lacombe wrote:
> This is likely to break the swith statement if the one of the enum member ever
> reach 63 ('?').
>
> Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
> ---
> scripts/kconfig/conf.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
> index 8e33aa7..057f49a 100644
> --- a/scripts/kconfig/conf.c
> +++ b/scripts/kconfig/conf.c
> @@ -503,10 +503,6 @@ int main(int ac, char **av)
> srand(seed);
> break;
> }
> - case '?':
> - fprintf(stderr, _("See README for usage info\n"));
> - exit(1);
> - break;
This code is correct, getopt_long() returns '?' if it encounters an
unknown option. At least the glibc implementation does so.
Michal
prev parent reply other threads:[~2010-12-15 13:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-05 6:52 [PATCH 1/2] kconfig/conf: kill deadcode Arnaud Lacombe
2010-12-05 6:52 ` [PATCH 2/2] kconfig/conf: add command line options' description Arnaud Lacombe
2010-12-05 6:56 ` Arnaud Lacombe
2010-12-15 6:28 ` Arnaud Lacombe
2010-12-15 6:23 ` [PATCH 1/2] kconfig/conf: kill deadcode Arnaud Lacombe
2010-12-15 13:58 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101215135850.GC18269@pobox.suse.cz \
--to=mmarek@suse.cz \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox