From: Michal Marek <mmarek@suse.cz>
To: Jan Beulich <JBeulich@novell.com>
Cc: linux-kbuild@vger.kernel.org, Arnaud Lacombe <lacombar@gmail.com>,
mchehab@redhat.com
Subject: Re: [PATCH] fix undesirable side effect of adding "visible" menu attribute
Date: Thu, 16 Dec 2010 22:26:14 +0100 [thread overview]
Message-ID: <20101216212614.GD21436@pobox.suse.cz> (raw)
In-Reply-To: <4D009D4A0200007800026DDB@vpn.id2.novell.com>
On Thu, Dec 09, 2010 at 08:11:38AM +0000, Jan Beulich wrote:
> This lead to non-selected, non-user-selectable options to be written
> out to .config. This is not only pointless, but also preventing the
> user to be prompted should any of those options eventually become
> visible (e.g. by de-selecting the *_AUTO options the "visible"
> attribute was added for.
>
> Furthermore it is quite logical for the "visible" attribute of a menu
> to control the visibility of all contained prompts, which is what the
> patch does.
>
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
It also fixes the issue that all{mod,yes}config set some options from
the invisible menus that cannot be selected interactively (e.g.
I2C_ALGOPCF, that is only selected by I2C_ELEKTOR on !SMP), so this
patch is
Acked-by: Michal Marek <mmarek@suse.cz>
unless Arnaud has a good reason not to take it.
Michal
next prev parent reply other threads:[~2010-12-16 21:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 8:11 [PATCH] fix undesirable side effect of adding "visible" menu attribute Jan Beulich
2010-12-09 15:58 ` Arnaud Lacombe
2010-12-09 16:07 ` Arnaud Lacombe
2010-12-09 16:40 ` Jan Beulich
2010-12-09 16:08 ` Jan Beulich
2010-12-16 21:26 ` Michal Marek [this message]
2010-12-16 23:49 ` Arnaud Lacombe
2010-12-17 2:03 ` Arnaud Lacombe
2010-12-17 7:53 ` Jan Beulich
2010-12-29 9:19 ` Michal Marek
2010-12-29 15:17 ` Arnaud Lacombe
2010-12-29 22:32 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216212614.GD21436@pobox.suse.cz \
--to=mmarek@suse.cz \
--cc=JBeulich@novell.com \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox