public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Jan Beulich <JBeulich@novell.com>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] miscellaneous Kconfig cleanup
Date: Mon, 20 Dec 2010 16:39:47 +0100	[thread overview]
Message-ID: <20101220153947.GD20492@sepie.suse.cz> (raw)
In-Reply-To: <4CFD1D7F0200007800026260@vpn.id2.novell.com>

On Mon, Dec 06, 2010 at 04:29:35PM +0000, Jan Beulich wrote:
> Even generally, having a defualt of "n" isn't very useful (as that's
> what kconfig defaults to anyway), but it is potentially going to cause
> confusion when enforced on options with invisible (or even withou any
> prompt: If such an option's prompt becomes visible later, the user
> will not be asked whether (s)he wants to turn on the option.
> 
> Besides that, use def_bool instead of the bool/default pair to make
> things a little shorter.
> 
> Signed-off-by: Jan Beulich <jbeulich@novell.com>

You can add
Acked-by: Michal Marek <mmarek@suse.cz>
on the patch if you like, but IMO this should go as individual patches
to the subsystem maintainers. Alternatively, you could use
trivial@kernel.org for such tree-wide fix.

Michal

      reply	other threads:[~2010-12-20 15:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-06 16:29 [PATCH] miscellaneous Kconfig cleanup Jan Beulich
2010-12-20 15:39 ` Michal Marek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101220153947.GD20492@sepie.suse.cz \
    --to=mmarek@suse.cz \
    --cc=JBeulich@novell.com \
    --cc=linux-kbuild@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox