From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kbuild-owner@vger.kernel.org>
Received: from moutng.kundenserver.de ([212.227.126.171]:56098 "EHLO
	moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751756Ab1AIODr (ORCPT
	<rfc822;linux-kbuild@vger.kernel.org>);
	Sun, 9 Jan 2011 09:03:47 -0500
From: Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/2] kbuild: asm-generic support
Date: Sun, 9 Jan 2011 15:03:33 +0100
References: <20110108130302.GA21698@merkur.ravnborg.org> <20110109082851.GA10463@merkur.ravnborg.org> <20110109083125.GA17045@merkur.ravnborg.org>
In-Reply-To: <20110109083125.GA17045@merkur.ravnborg.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201101091503.34783.arnd@arndb.de>
Sender: linux-kbuild-owner@vger.kernel.org
List-ID: <linux-kbuild.vger.kernel.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: lkml <linux-kernel@vger.kernel.org>, linux-kbuild <linux-kbuild@vger.kernel.org>, linux arch <linux-arch@vger.kernel.org>, Guan Xuetao <guanxuetao@mprc.pku.edu.cn>, Michal Marek <mmarek@suse.cz>, Stephen Rothwell <sfr@canb.auug.org.au>

Hi Sam,

Looks much cleaner to me now, but I still don't see why we even need
the new generic-export-y variable in addition to export-y. Can't we
just simply install all $(filter-out, $(generated-y), $(header-y))
from arch/$(SRCARCH)/include/asm and all $(filter, $(generated-y),
$(header-y)) from rch/$(SRCARCH)/include/generated/asm?

I think that would lead to a less confusing set of rules.

On Sunday 09 January 2011, Sam Ravnborg wrote:
>  ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/kvm.h \
>                   $(srctree)/include/asm-$(SRCARCH)/kvm.h),)
> -header-y  += kvm.h
> +generic-export-y  += kvm.h
>  endif
>  
>  ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/kvm_para.h \
>                   $(srctree)/include/asm-$(SRCARCH)/kvm_para.h),)
> -header-y  += kvm_para.h
> +generic-export-y  += kvm_para.h
>  endif
>  
>  ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/a.out.h \
>                   $(srctree)/include/asm-$(SRCARCH)/a.out.h),)
> -header-y += a.out.h
> +generic-export-y += a.out.h
>  endif

We can probably use the opportunity to clean this up as well, I never
like the idea of conditionalizing the installation of a header on the
presence of the file. Instead, we could either generate these headers
from new generic versions of them, or just put the header-y+= into
arch/$(SRCARCH)/include/asm/Kbuild where it belonged in the first
place.

The Kbuild.asm file was initially meant to list the files that are
exported from every architecture, so we could see the exact differences
in each architecture from its asm/Kbuild file.

	Arnd