From: maximilian attems <max@stro.at>
To: Robert Gordon <robert@greenroomsoftware.com>
Cc: linux-kbuild@vger.kernel.org, Robert Nelson <robertcnelson@gmail.com>
Subject: Re: [PATCH] kbuild, deb-pkg: set host machine after dpkg-gencontrol
Date: Mon, 18 Apr 2011 16:06:26 +0000 [thread overview]
Message-ID: <20110418160625.GA13973@vostochny.stro.at> (raw)
In-Reply-To: <20110417222945.GC14561@stro.at>
On Mon, Apr 18, 2011 at 12:29:45AM +0200, maximilian attems wrote:
> On Fri, 15 Apr 2011, Robert Gordon wrote:
>
> > This patch was prepared using git format-patch and git send-email. Details follow.
> > Regards,
> > Robert Gordon
>
> thanks so the patch was now applyable and so testable. (:
>
> > scripts/package/builddeb script was setting the host machine $arch in the KERNEL/debian/control prior to an invocation of dpkg-gencontrol. The patch modifies the script to guarantee the correct debian arch for the target is written to the control file instead. The issue originally arose in the 2.6.38 series.
>
> hmm don't be shy to use line-breaks in the desc for next times..
>
> > Signed-off-by: Robert Gordon <robert@greenroomsoftware.com>
>
> rudimentary testing showed, that `make deb-pkg` works,
> but `make ARCH=i386 deb-pkg` on an amd64 Debian box seems borked:
> + dpkg-gencontrol -isp -DArchitecture=i386 -plinux-headers-2.6.39-rc3+
> -P/media/data/mattems/src/linux-2.6/debian/hdrtmp
> dpkg-gencontrol: error: current host architecture 'amd64' does not appear in package's architecture list (i386)
at a second look your patch is just wrong the arch overriding is
currently correctly done in create_package(), with the debian/control
file having the host arch written to it.
so please post what exactly you were trying to build in the first place?
--
maks
next prev parent reply other threads:[~2011-04-18 16:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 18:23 [PATCH] kbuild, deb-pkg: set host machine after dpkg-gencontrol Robert Gordon
2011-04-17 22:29 ` maximilian attems
2011-04-17 22:34 ` Robert Nelson
2011-04-18 11:13 ` Michal Marek
2011-04-18 16:06 ` maximilian attems [this message]
2011-04-18 19:28 ` robert
2011-04-19 14:33 ` maximilian attems
2011-04-20 17:35 ` Robert Gordon
2011-04-22 20:24 ` Robert Gordon
-- strict thread matches above, loose matches on Subject: below --
2011-04-13 21:20 Robert
2011-04-13 22:47 ` maximilian attems
2011-04-14 13:11 ` robert
2011-04-14 13:37 ` Robert Nelson
2011-04-14 14:24 ` robert
2011-04-14 14:38 ` maximilian attems
2011-04-14 14:40 ` maximilian attems
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110418160625.GA13973@vostochny.stro.at \
--to=max@stro.at \
--cc=linux-kbuild@vger.kernel.org \
--cc=robert@greenroomsoftware.com \
--cc=robertcnelson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox