Re: [RFC PATCH] kbuild: implement several W= levels

Borislav Petkov
2011-04-22T10:20:31Z

Hi Sam,

On Fri, Apr 22, 2011 at 12:15:24PM +0200, Sam Ravnborg wrote:
> Hi Borislav.
>
> > > the patch is only an RFC - and is not made on top
> > > of an upstream kernel with no additiona stuff applied.
> >
> > Thanks for doing this, a couple of suggestions below.
> ...
>
> You already spend more time analysing this than it took me
> to write the patch.
> Can I persuade you to implement the various W= levels based
> on your analysis and send to Michal for merging?
> You can use my v2 PATCH as inspiration.
>
> Please take authorship on the patch as the main work
> is to decide what warnings belongs to which level.
>
> [Snipped - lots of good comments]

thanks but according to Documentation/SubmittingPatches, the _initial_
author is the author of the patch. Besides, I just had the talk with
Ingo the other day on how to acknowledge multuple authors so I'm not
making the same mistake again :).

But seriously, let me add my comments to your patch while they're fresh
in my head and let's see what we come up with in our combined and
perfectly orchestrated effort :).

Thanks.

--
Regards/Gruss,
Boris.