From: Michal Marek <mmarek@suse.cz>
To: Arnaud Lacombe <lacombar@gmail.com>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [RFC 1/9] genksyms: rename parser files
Date: Thu, 5 May 2011 16:18:33 +0200 [thread overview]
Message-ID: <20110505141833.GF13293@sepie.suse.cz> (raw)
In-Reply-To: <1304561004-2684-2-git-send-email-lacombar@gmail.com>
On Wed, May 04, 2011 at 10:03:16PM -0400, Arnaud Lacombe wrote:
> Rename parser's files to make them follow the same convention as `kconfig'.
This mail didn't reach the mailing list, probably for size reasons. I
suggest you create the patch with the -M option, it will be a bit harder to
apply, but people will be able to see it.
> ---
> scripts/genksyms/genksyms.gperf | 56 +
> scripts/genksyms/genksyms.hash.c_shipped | 220 +++
> scripts/genksyms/genksyms.l | 409 +++++
> scripts/genksyms/genksyms.tab.c_shipped | 2353 ++++++++++++++++++++++++++
> scripts/genksyms/genksyms.tab.h_shipped | 139 ++
> scripts/genksyms/genksyms.y | 473 ++++++
> scripts/genksyms/keywords.c_shipped | 220 ---
> scripts/genksyms/keywords.gperf | 56 -
> scripts/genksyms/lex.c_shipped | 2709 ------------------------------
> scripts/genksyms/lex.genksyms.c_shipped | 2709 ++++++++++++++++++++++++++++++
> scripts/genksyms/lex.l | 409 -----
> scripts/genksyms/parse.c_shipped | 2353 --------------------------
> scripts/genksyms/parse.h_shipped | 139 --
> scripts/genksyms/parse.y | 473 ------
Renaming lex.l is a good idea, lex.lex.c would look silly. But I would
leave parse.y and keywords.gperf and only rename the _shipped files to
match what the new rules do. The names are local to the directory, so
there is no urgent need to change them (and the history is easier to
view if there are fewer renames).
Michal
next prev parent reply other threads:[~2011-05-05 14:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 2:03 [RFC 0/9] Kbuild: factor parser rules Arnaud Lacombe
2011-05-05 2:03 ` [RFC 2/9] genksyms: finalize rename Arnaud Lacombe
2011-05-05 2:06 ` Arnaud Lacombe
2011-05-05 14:23 ` Michal Marek
2011-05-23 2:17 ` Arnaud Lacombe
2011-05-23 3:32 ` Arnaud Lacombe
2011-05-05 2:03 ` [RFC 3/9] genksyms: pass hash and lookup functions name and target language though the input file Arnaud Lacombe
2011-05-05 2:03 ` [RFC 4/9] genksyms: regen parser Arnaud Lacombe
2011-05-05 2:03 ` [RFC 5/9] kconfig: constify `kconf_id_lookup' Arnaud Lacombe
2011-05-05 2:03 ` [RFC 6/9] kconfig: regen parsers Arnaud Lacombe
2011-05-05 2:03 ` [RFC 7/9] kbuild: merge parser generation rules Arnaud Lacombe
2011-05-05 13:32 ` Michal Marek
2011-05-05 14:50 ` Arnaud Lacombe
2011-05-05 2:03 ` [RFC 8/9] kconfig: regen parser Arnaud Lacombe
2011-05-05 2:03 ` [RFC 9/9] genksyms: " Arnaud Lacombe
[not found] ` <1304561004-2684-2-git-send-email-lacombar@gmail.com>
2011-05-05 14:18 ` Michal Marek [this message]
2011-05-23 2:06 ` [RFC 1/9] genksyms: rename parser files Arnaud Lacombe
2011-05-23 5:48 ` Arnaud Lacombe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110505141833.GF13293@sepie.suse.cz \
--to=mmarek@suse.cz \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox