From: Michal Marek <mmarek@suse.cz>
To: Arnaud Lacombe <lacombar@gmail.com>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [RFC 2/9] genksyms: finalize rename
Date: Thu, 5 May 2011 16:23:05 +0200 [thread overview]
Message-ID: <20110505142305.GG13293@sepie.suse.cz> (raw)
In-Reply-To: <1304561004-2684-3-git-send-email-lacombar@gmail.com>
On Wed, May 04, 2011 at 10:03:17PM -0400, Arnaud Lacombe wrote:
> ---
> scripts/genksyms/.gitignore | 6 ++--
> scripts/genksyms/Makefile | 45 +++++++++++++-----------------------------
> scripts/genksyms/genksyms.c | 11 ++++-----
> scripts/genksyms/genksyms.l | 7 ++---
> scripts/genksyms/genksyms.y | 2 +
> 5 files changed, 27 insertions(+), 44 deletions(-)
>
> diff --git a/scripts/genksyms/.gitignore b/scripts/genksyms/.gitignore
> index be5cadb..0983577 100644
> --- a/scripts/genksyms/.gitignore
> +++ b/scripts/genksyms/.gitignore
> @@ -1,4 +1,4 @@
> -keywords.c
> -lex.c
> -parse.[ch]
> genksyms
> +genksyms.tab.c
> +lex.genksyms.c
> +genksyms.hash.c
> diff --git a/scripts/genksyms/Makefile b/scripts/genksyms/Makefile
> index e420fe4..82bb25f 100644
> --- a/scripts/genksyms/Makefile
> +++ b/scripts/genksyms/Makefile
> @@ -2,52 +2,35 @@
> hostprogs-y := genksyms
> always := $(hostprogs-y)
>
> -genksyms-objs := genksyms.o parse.o lex.o
> +genksyms-objs := genksyms.o genksyms.tab.o
>
> # -I needed for generated C source (shipped source)
> HOSTCFLAGS_parse.o := -Wno-uninitialized -I$(src)
>
> -# dependencies on generated files need to be listed explicitly
> -$(obj)/lex.o: $(obj)/parse.h $(obj)/keywords.c
> -
> # -I needed for generated C source (shipped source)
> HOSTCFLAGS_lex.o := -I$(src)
>
> -ifdef GENERATE_PARSER
> -
> -# gperf
> +clean-files := genksyms.tab.c lex.genksyms.c genksyms.hash.c
Given that you are overwriting most of this by "kbuild: merge parser
generation rules", I suggest you only do the necessary minimum at this
point, i.e. only reflect the file renames and #include the lexer into
the parser.
Michal
next prev parent reply other threads:[~2011-05-05 14:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 2:03 [RFC 0/9] Kbuild: factor parser rules Arnaud Lacombe
2011-05-05 2:03 ` [RFC 2/9] genksyms: finalize rename Arnaud Lacombe
2011-05-05 2:06 ` Arnaud Lacombe
2011-05-05 14:23 ` Michal Marek [this message]
2011-05-23 2:17 ` Arnaud Lacombe
2011-05-23 3:32 ` Arnaud Lacombe
2011-05-05 2:03 ` [RFC 3/9] genksyms: pass hash and lookup functions name and target language though the input file Arnaud Lacombe
2011-05-05 2:03 ` [RFC 4/9] genksyms: regen parser Arnaud Lacombe
2011-05-05 2:03 ` [RFC 5/9] kconfig: constify `kconf_id_lookup' Arnaud Lacombe
2011-05-05 2:03 ` [RFC 6/9] kconfig: regen parsers Arnaud Lacombe
2011-05-05 2:03 ` [RFC 7/9] kbuild: merge parser generation rules Arnaud Lacombe
2011-05-05 13:32 ` Michal Marek
2011-05-05 14:50 ` Arnaud Lacombe
2011-05-05 2:03 ` [RFC 8/9] kconfig: regen parser Arnaud Lacombe
2011-05-05 2:03 ` [RFC 9/9] genksyms: " Arnaud Lacombe
[not found] ` <1304561004-2684-2-git-send-email-lacombar@gmail.com>
2011-05-05 14:18 ` [RFC 1/9] genksyms: rename parser files Michal Marek
2011-05-23 2:06 ` Arnaud Lacombe
2011-05-23 5:48 ` Arnaud Lacombe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110505142305.GG13293@sepie.suse.cz \
--to=mmarek@suse.cz \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox