From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kbuild-owner@vger.kernel.org>
Received: from 64.mail-out.ovh.net ([91.121.185.65]:50071 "HELO
	64.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with SMTP id S1758131Ab1EMIru (ORCPT
	<rfc822;linux-kbuild@vger.kernel.org>);
	Fri, 13 May 2011 04:47:50 -0400
Date: Fri, 13 May 2011 10:36:52 +0200
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Subject: Re: [PATCH v2] kconfig: autogenerated config_is_xxx macro
Message-ID: <20110513083652.GP18952@game.jcrosoft.org>
References: <1304658229-30820-1-git-send-email-plagnioj@jcrosoft.com>
 <BANLkTi=s8w01NHnxB7cfCvy4ZS5GnUABZg@mail.gmail.com>
 <20110507015041.GA21017@game.jcrosoft.org>
 <4DC7AB57.9050002@suse.cz>
 <20110513080909.GO18952@game.jcrosoft.org>
 <20110513083013.GC13647@elte.hu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110513083013.GC13647@elte.hu>
Sender: linux-kbuild-owner@vger.kernel.org
List-ID: <linux-kbuild.vger.kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Michal Marek <mmarek@suse.cz>, Arnaud Lacombe <lacombar@gmail.com>, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, x86@kernel.org, Ingo Molnar <mingo@redhat.com>

On 10:30 Fri 13 May     , Ingo Molnar wrote:
> 
> * Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:
> 
> > -#ifdef CONFIG_PCI_BIOS
> > -	if (!rt->signature) {
> > +	if (config_is_pci_bios() && !rt->signature) {
> 
> Makes sense - but please name it in a more obvious way, such as:
> 
> 	pci_bios_enabled()
the idea to generate the macro via Kconfig

so I propose config_is_pci_bios() and if it's a module
config_is_pci_bios_module()

if you have a better convention naming I'm fine to change it

maybe

config_pci_bios_enabled() / config_pci_bios_module_enabled

or 

pci_bios_enabled() / pci_bios_module_enabled()

Best Regards,
J.