* [PATCH 1/2] gconfig: enable rules hint for main treeviews
@ 2011-05-19 12:37 Eduardo Silva
2011-05-19 16:13 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Eduardo Silva @ 2011-05-19 12:37 UTC (permalink / raw)
To: Roman Zippel; +Cc: linux-kbuild, linux-kernel
Due to the large amount of rows in the treeviews, is difficult to
match columns with rows, setting the rules hint to 'true' allows the
treeview to alternate background colors in the rows making the data
more readable.
Signed-off-by: Eduardo Silva <edsiper@gmail.com>
---
scripts/kconfig/gconf.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
index 4558961..0c8db7d 100644
--- a/scripts/kconfig/gconf.c
+++ b/scripts/kconfig/gconf.c
@@ -253,7 +253,7 @@ void init_left_tree(void)
gtk_tree_view_set_model(view, model1);
gtk_tree_view_set_headers_visible(view, TRUE);
- gtk_tree_view_set_rules_hint(view, FALSE);
+ gtk_tree_view_set_rules_hint(view, TRUE);
column = gtk_tree_view_column_new();
gtk_tree_view_append_column(view, column);
@@ -298,7 +298,7 @@ void init_right_tree(void)
gtk_tree_view_set_model(view, model2);
gtk_tree_view_set_headers_visible(view, TRUE);
- gtk_tree_view_set_rules_hint(view, FALSE);
+ gtk_tree_view_set_rules_hint(view, TRUE);
column = gtk_tree_view_column_new();
gtk_tree_view_append_column(view, column);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] gconfig: enable rules hint for main treeviews
2011-05-19 12:37 [PATCH 1/2] gconfig: enable rules hint for main treeviews Eduardo Silva
@ 2011-05-19 16:13 ` Randy Dunlap
2011-05-24 13:55 ` Michal Marek
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2011-05-19 16:13 UTC (permalink / raw)
To: Eduardo Silva; +Cc: Roman Zippel, linux-kbuild, linux-kernel
On Thu, 19 May 2011 08:37:01 -0400 Eduardo Silva wrote:
> Due to the large amount of rows in the treeviews, is difficult to
> match columns with rows, setting the rules hint to 'true' allows the
> treeview to alternate background colors in the rows making the data
> more readable.
>
> Signed-off-by: Eduardo Silva <edsiper@gmail.com>
Tested-by: Randy Dunlap <randy.dunlap@oracle.com>
Nice. Thanks.
> ---
> scripts/kconfig/gconf.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
> index 4558961..0c8db7d 100644
> --- a/scripts/kconfig/gconf.c
> +++ b/scripts/kconfig/gconf.c
> @@ -253,7 +253,7 @@ void init_left_tree(void)
>
> gtk_tree_view_set_model(view, model1);
> gtk_tree_view_set_headers_visible(view, TRUE);
> - gtk_tree_view_set_rules_hint(view, FALSE);
> + gtk_tree_view_set_rules_hint(view, TRUE);
>
> column = gtk_tree_view_column_new();
> gtk_tree_view_append_column(view, column);
> @@ -298,7 +298,7 @@ void init_right_tree(void)
>
> gtk_tree_view_set_model(view, model2);
> gtk_tree_view_set_headers_visible(view, TRUE);
> - gtk_tree_view_set_rules_hint(view, FALSE);
> + gtk_tree_view_set_rules_hint(view, TRUE);
>
> column = gtk_tree_view_column_new();
> gtk_tree_view_append_column(view, column);
> --
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] gconfig: enable rules hint for main treeviews
2011-05-19 16:13 ` Randy Dunlap
@ 2011-05-24 13:55 ` Michal Marek
0 siblings, 0 replies; 3+ messages in thread
From: Michal Marek @ 2011-05-24 13:55 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Eduardo Silva, Roman Zippel, linux-kbuild, linux-kernel
On Thu, May 19, 2011 at 09:13:09AM -0700, Randy Dunlap wrote:
> On Thu, 19 May 2011 08:37:01 -0400 Eduardo Silva wrote:
>
> > Due to the large amount of rows in the treeviews, is difficult to
> > match columns with rows, setting the rules hint to 'true' allows the
> > treeview to alternate background colors in the rows making the data
> > more readable.
> >
> > Signed-off-by: Eduardo Silva <edsiper@gmail.com>
>
> Tested-by: Randy Dunlap <randy.dunlap@oracle.com>
>
> Nice. Thanks.
Applied, thanks.
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-24 13:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-19 12:37 [PATCH 1/2] gconfig: enable rules hint for main treeviews Eduardo Silva
2011-05-19 16:13 ` Randy Dunlap
2011-05-24 13:55 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox