From: Greg KH <greg@kroah.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Arnaud Lacombe <lacombar@gmail.com>,
Michal Nazarewicz <mina86@mina86.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Linux USB Mailing List <linux-usb@vger.kernel.org>,
linux-kbuild@vger.kernel.org
Subject: Re: generate one module from multiple object files (was: Re: [PATCH 2/2] usb: gadget: convert all users to the new udc)
Date: Tue, 14 Jun 2011 13:24:51 -0700 [thread overview]
Message-ID: <20110614202451.GA17182@kroah.com> (raw)
In-Reply-To: <20110614201632.GD30763@legolas.emea.dhcp.ti.com>
On Tue, Jun 14, 2011 at 11:16:33PM +0300, Felipe Balbi wrote:
> Hi,
>
> On Tue, Jun 14, 2011 at 04:01:29PM -0400, Alan Stern wrote:
> > Consider usbcore as an example. Grepping through drivers/usb/core/*.c,
> > you'll see there are init routines in devio.c, inode.c, and usb.c.
> > These files are all compiled separately. Yet they are linked into a
> > single object module, usbcore.ko, and the init sections work out just
> > fine.
> >
> > In short, I don't see what's wrong with separate compilation.
> > Apparently the only problem David found was that it increased the size
> > of the final driver by 42 bytes. Is that really worth worrying about?
>
> probably not... But Greg initiated the discussion. It was something
> related with always recompiling the same objects or something. I really
> don't recall.
42 bytes is not worth worrying about :)
If it can be merged into a single .ko that the others use, please do it.
But for some reason I had problems the last time I tried it, but I can't
remember what they were.
greg k-h
next prev parent reply other threads:[~2011-06-14 20:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110613085534.GD3633@legolas.emea.dhcp.ti.com>
[not found] ` <Pine.LNX.4.44L0.1106131024100.1983-100000@iolanthe.rowland.org>
[not found] ` <20110613153516.GC2353@legolas.emea.dhcp.ti.com>
[not found] ` <op.vw1yw3ol3l0zgt@mnazarewicz-glaptop>
2011-06-14 7:32 ` generate one module from multiple object files (was: Re: [PATCH 2/2] usb: gadget: convert all users to the new udc) Felipe Balbi
2011-06-14 15:33 ` Arnaud Lacombe
2011-06-14 16:45 ` Felipe Balbi
2011-06-14 17:06 ` Alan Stern
2011-06-14 17:16 ` Sebastian Andrzej Siewior
2011-06-14 17:29 ` Felipe Balbi
2011-06-14 17:48 ` Arnaud Lacombe
2011-06-14 18:36 ` Felipe Balbi
2011-06-14 20:21 ` Greg KH
2011-06-14 19:27 ` Alan Stern
2011-06-14 19:41 ` Felipe Balbi
2011-06-14 20:01 ` Alan Stern
2011-06-14 20:16 ` Felipe Balbi
2011-06-14 20:24 ` Greg KH [this message]
2011-06-14 17:15 ` Arnaud Lacombe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110614202451.GA17182@kroah.com \
--to=greg@kroah.com \
--cc=balbi@ti.com \
--cc=bigeasy@linutronix.de \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox