Re: [PATCH 2/2] kconfig/nconf: prevent segfault on empty menu

[Michal Marek <mmarek@suse.cz>]

On Sun, Jul 10, 2011 at 03:27:05AM -0400, Arnaud Lacombe wrote:
> nconf does not check the validity of the current menu when help is requested
> (with either <F2>, '?' or 'h'). This leads to a NULL pointer dereference when an
> empty menu is encountered.
> 
> The following reduced testcase exposes the problem:
> 
> config DEP
>         bool
> 
> menu "FOO"
> 
> config BAR
>         bool "BAR"
>         depends on DEP
> 
> endmenu
> 
> Issue will happen when entering menu "FOO" and requesting help.
> 
> nconf is the only front-end which do not filter the validity of the current
> menu. Such filter can not really happen beforehand as other key which does not
> deals with the current menu might be entered by the user, so just bails out
> earlier if we encounter an invalid menu.
> 
> Cc: Nir Tzachar <nir.tzachar@gmail.com>
> Cc: Andrej Gelenberg <andrej.gelenberg@udo.edu>
> Reported-by: Andrej Gelenberg <andrej.gelenberg@udo.edu>
> Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>

Thanks, applied both patches to kbuild-2.6.git#kconfig.

Michal