From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.snhosting.dk ([87.238.248.203]:42794 "EHLO smtp.domainteam.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750993Ab1J0Tev (ORCPT ); Thu, 27 Oct 2011 15:34:51 -0400 Date: Thu, 27 Oct 2011 21:34:48 +0200 From: Sam Ravnborg Subject: Re: [PATCH] config: Add 'make kvmconfig' Message-ID: <20111027193448.GA3514@merkur.ravnborg.org> References: <1319717234-20918-1-git-send-email-levinsasha928@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1319717234-20918-1-git-send-email-levinsasha928@gmail.com> Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Sasha Levin Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Linus Torvalds , Michal Marek , Pekka Enberg , linux-kbuild@vger.kernel.org On Thu, Oct 27, 2011 at 02:07:14PM +0200, Sasha Levin wrote: > This patch adds 'make kvmconfig' which allows to add KVM guest support > to a config file. > > This allows for easier testing of configurations under virtualized > environments. > > Cc: Ingo Molnar > Cc: Linus Torvalds > Cc: Michal Marek > Cc: Pekka Enberg > Cc: linux-kbuild@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Suggested-by: Ingo Molnar > Signed-off-by: Sasha Levin Two points about the implmentation that I do not like... The kvmconfig is an x86 specific thing - so it does not belong in the scripts/kconfig/Makefile The *config namespace is general config targets. Suggestion: Move the implmentation to arch/x86/Makefile and name the target something that does not match the *config pattern. Suggestion: make kvmbootable To tell that this convert the current config to a kvmbootable config. And then add the target to the x86 specific help too. Sam