Re: [PATCH] config: Add 'make kvmconfig'

Michal Marek
2011-11-02T09:07:29Z

On 2.11.2011 09:41, Ingo Molnar wrote:
>
> * Matthias Schniedermeyer <ms@citd.de> wrote:
>
>> And AFAICS there currently is no "modconfig", only an
>> "allmodconfig" (and "localmodconfig")
>>
>> With no letters dropped it would be less ambiguous. make
>> modifyconfig=kvm
>
> Yeah. Note that it's more like an 'add' operation, not a modify
> operation, thus:
>
> make addconfig=kvm
>
> or:
>
> make addconfig kvm
>
> would be intuitive and would work well too.
>
> Sam, Michal, which one would you prefer? The latter might have the
> advantage that it's additive, enabling future usages like:
>
> make addconfig kvm debug

The problem is that neither of these fit into the make command syntax:

make addconfig kvm debug

tells make to build three different targets, and

make addconfig=kvm

tells make to create a variable named addconfig with the value kvm and
build the default target. And BTW, you or someone else reassured me
earlier in the thread that this is going to be needed for the kvm case
solely, so why are you inventing something generic now? :)

Michal