From: Sam Ravnborg <sam@ravnborg.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Guillem Jover <guillem@hadrons.org>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-api@vger.kernel.org, Michal Marek <mmarek@suse.cz>
Subject: Re: [PATCH] Use __unused0 instead of __unused for user visible struct member names
Date: Tue, 3 Jan 2012 07:56:59 +0100 [thread overview]
Message-ID: <20120103065659.GA32216@merkur.ravnborg.org> (raw)
In-Reply-To: <20120102202243.GA31103@elie.hsd1.il.comcast.net>
On Mon, Jan 02, 2012 at 02:22:43PM -0600, Jonathan Nieder wrote:
> (+cc: some possible relevant people)
> Hi,
>
> Guillem Jover wrote:
>
> > On BSD systems __unused has traditionally been defined to mean the
> > equivalent of gcc's __attribute__((__unused__)), some parts of the
> > Linux tree use that convention too (e.g. perf). The problem comes when
> > defining such macro while trying to build unmodified source code with
> > BSD origins on systems with Linux headers.
> >
> > Rename the user visible struct members from __unused to __unused0 to
> > not cause compilation failures due to that macro, which should not be
> > a problem as those members are supposed to be private anyway.
^__ is reserved for libc internal stuff and there is no reason to
name the unused/padding members "__unused".
So one or a set of patches that rename them all to something more
sensible would be fine.
Sam
next prev parent reply other threads:[~2012-01-03 7:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120102024418.GA10483@gaara.hadrons.org>
2012-01-02 20:22 ` [PATCH] Use __unused0 instead of __unused for user visible struct member names Jonathan Nieder
2012-01-03 6:56 ` Sam Ravnborg [this message]
2012-01-04 8:14 ` Guillem Jover
2012-01-04 11:03 ` Michal Marek
2012-01-04 13:35 ` Sam Ravnborg
2013-11-11 14:59 ` Thorsten Glaser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120103065659.GA32216@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=guillem@hadrons.org \
--cc=jrnieder@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox